Skip to content
This repository was archived by the owner on Jul 11, 2023. It is now read-only.

test(pkg/utils): Check errors generically for NewGrpc test #1790

Merged
merged 1 commit into from
Oct 5, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(pkg/utils): Check if error occured for NewGrpc
  • Loading branch information
ksubrmnn committed Oct 5, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit e063853b67577834a683ce196e671edc52c79de8
12 changes: 6 additions & 6 deletions pkg/utils/grpc_test.go
Original file line number Diff line number Diff line change
@@ -27,25 +27,25 @@ func TestNewGrpc(t *testing.T) {
serverType string
port int
certPem []byte
expectedError string
expectedError bool
}

newGrpcTests := []newGrpcTest{
{"abc", 123, emptyByteArray, "listen tcp :123: bind: permission denied"},
{"ADS", 8081, emptyByteArray, "[grpc][mTLS][ADS] Failed loading Certificate ([]) and Key"},
{"ADS", 8080, certPem, ""},
{"abc", 123, emptyByteArray, true},
{"ADS", 8081, emptyByteArray, true},
{"ADS", 8080, certPem, false},
}

for _, gt := range newGrpcTests {
resServer, resListener, err := NewGrpc(gt.serverType, gt.port, gt.certPem, keyPem, rootPem)
if err != nil {
assert.Nil(resServer)
assert.Nil(resListener)
assert.Contains(err.Error(), gt.expectedError)
assert.True(gt.expectedError)
} else {
assert.NotNil(resServer)
assert.NotNil(resListener)
assert.Empty(gt.expectedError)
assert.False(gt.expectedError)
}
}
}
13 changes: 0 additions & 13 deletions pkg/utils/suite_test.go

This file was deleted.