This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
Delete Certificate for an Envoy for a Pod that was Terminated #1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ref #1719 |
draychev
force-pushed
the
cleanup-stale-certs--1
branch
2 times, most recently
from
2848660 to
3fce8c8
Compare
draychev
changed the title
draychev
force-pushed
the
cleanup-stale-certs--1
branch
8 times, most recently
from
cc513be to
f9b0d3c
Compare
Codecov Report
@@ Coverage Diff @@
## main #1956 +/- ##
==========================================
+ Coverage 57.30% 57.37% +0.07%
==========================================
Files 139 140 +1
Lines 5692 5739 +47
==========================================
+ Hits 3262 3293 +31
- Misses 2427 2443 +16
Partials 3 3
Continue to review full report at Codecov.
|
draychev
force-pushed
the
cleanup-stale-certs--1
branch
4 times, most recently
from
bbaebee to
a8aafeb
Compare
draychev
force-pushed
the
cleanup-stale-certs--1
branch
10 times, most recently
from
c568549 to
0ed5cbc
Compare
draychev
force-pushed
the
cleanup-stale-certs--1
branch
from
0ed5cbc to
85787b4
Compare
michelleN
reviewed
Nov 13, 2020
|
|
||
| var errEventNotHandled = errors.New("event not handled") | ||
|
|
||
| func (mc *MeshCatalog) releaseCertificate(ann announcements.Announcement) error { |
There was a problem hiding this comment.
I know the function is not exported but would you mind adding a comment for this function anyway?
There was a problem hiding this comment.
Good idea to document these! Added a docstring here!
|
|
||
| func (mc *MeshCatalog) releaseCertificate(ann announcements.Announcement) error { | ||
| whatWeGot := ann.Type | ||
| whatWeCanHandle := announcements.PodDeleted |
There was a problem hiding this comment.
love these variable names
shashankram
previously approved these changes
Nov 13, 2020
eduser25
reviewed
Nov 14, 2020
snehachhabria
previously approved these changes
Nov 16, 2020
draychev
dismissed stale reviews from snehachhabria and shashankram
via
90e7993
eduser25
approved these changes
Nov 16, 2020
snehachhabria
approved these changes
Nov 17, 2020
draychev
added a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
draychev
added a commit
to draychev/osm
that referenced
this pull request
Nov 19, 2020
draychev
added a commit
to draychev/osm
that referenced
this pull request
Dec 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove certificates for Pods that have been terminated. Without this we would continue to issue certificates and keep them in cache for the life of the OSM Controller pod.
This PR introduces 2 new functions (within Mesh Catalog):
releaseCertificate()updateRelatedProxies()These functions will be evaluated (sequentially) when an
Announcementof typePodDeletedarrives.To help find the certificate for a given Pod (identified by its Kubernetes UID), this PR introduces
podUIDToCNinto Mesh Catalog. This is a thread safe map, which will be populated with Pod UID to Certificate mapping.This PR will fix #1719
After this I am going to hand-off the work around refining and rearchitecting the OSM eventing to @eduser25 and @shashankram who will continue to hack on the signaling mechanism.
I hope that the changes I made here would be easily translated to whatever system we come up with to handle these events in the future. I deliberately did not go into future-proofing this - we could add the entire Kubernetes object in the Announcement or launch the handlers in goroutines to unblock. I'm leaving this for another iteration (and if at all necessary).
Affected area:
Please answer the following questions with yes/no.