This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
RFC: Add announcements package & mesage handler #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1957 +/- ##
==========================================
- Coverage 58.45% 58.43% -0.03%
==========================================
Files 131 131
Lines 5284 5288 +4
==========================================
+ Hits 3089 3090 +1
- Misses 2192 2195 +3
Partials 3 3
Continue to review full report at Codecov.
|
shashankram
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
The announcements package could implement a pub-sub model if we decide to do so for #1914
shalier
approved these changes
Oct 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the skeleton of a new package
pkg/announcements. This package is intended to contain the types for the messages that will be passed around via the announcement system OSM employs.In this PR we also include an example of how this may be used: every announcement
interface{}is examined / type asserted to see if it isAnnouncement{}. When it is - it is passed to a handler, which could further examine the properties of the message and do something specific.The first use case for this more specific messaging system would be #1719, where we need to react to Pod Deletion events and clean-up relevant certificates.
For more context on how this could be used - see draft PR here: #1956
Affected area:
Please answer the following questions with yes/no.