Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog: Convert connectedProxies to sync.Map #2061

Merged

Conversation

draychev
Copy link
Contributor

To simplify things, this PR changes the

	connectedProxies     map[certificate.CommonName]connectedProxy		
	connectedProxiesLock sync.Mutex

with

	connectedProxies sync.Map

There are 2 other similar fields that will be changed with another PR to keep things simple and clean.


Ran a quick test to verify the debug server works as expected;

image


Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?

@codecov-io
Copy link

Codecov Report

Merging #2061 (c8e220f) into main (e533370) will decrease coverage by 0.02%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2061      +/-   ##
==========================================
- Coverage   57.80%   57.77%   -0.03%     
==========================================
  Files         141      141              
  Lines        5794     5790       -4     
==========================================
- Hits         3349     3345       -4     
  Misses       2443     2443              
  Partials        2        2              
Impacted Files Coverage Δ
pkg/catalog/catalog.go 100.00% <ø> (ø)
pkg/catalog/repeater.go 29.62% <0.00%> (-1.14%) ⬇️
pkg/catalog/debugger.go 97.22% <100.00%> (+2.62%) ⬆️
pkg/catalog/proxy.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e533370...c8e220f. Read the comment docs.

@draychev draychev merged commit 8ad74fb into openservicemesh:main Nov 16, 2020
@draychev draychev deleted the use-sync-map-for-connected-proxies branch November 16, 2020 17:36
draychev added a commit to draychev/osm that referenced this pull request Nov 19, 2020
draychev added a commit to draychev/osm that referenced this pull request Nov 19, 2020
draychev added a commit to draychev/osm that referenced this pull request Dec 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants