Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

fix(make): update e2e kind cluster flag #2384

Merged
merged 1 commit into from
Jan 26, 2021
Merged

fix(make): update e2e kind cluster flag #2384

merged 1 commit into from
Jan 26, 2021

Conversation

nojnhuh
Copy link
Contributor

@nojnhuh nojnhuh commented Jan 26, 2021

Description:
This flag changed from -kindCluster to -installType=KindCluster but
the Makefile wasn't updated. This change adds the fix so make test-e2e
doesn't throw an error for the unknown flag.

Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [X]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

This flag changed from `-kindCluster` to `-installType=KindCluster` but
the Makefile wasn't updated. This change adds the fix so `make test-e2e`
doesn't throw an error for the unknown flag.

Signed-off-by: Jon Huhn <johuhn@microsoft.com>
@nojnhuh nojnhuh requested a review from a team as a code owner January 26, 2021 17:51
@codecov-io
Copy link

Codecov Report

Merging #2384 (bfdfc0f) into main (377a47f) will decrease coverage by 0.07%.
The diff coverage is 22.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2384      +/-   ##
==========================================
- Coverage   58.53%   58.46%   -0.08%     
==========================================
  Files         149      149              
  Lines        6669     6669              
==========================================
- Hits         3904     3899       -5     
- Misses       2751     2756       +5     
  Partials       14       14              
Impacted Files Coverage Δ
...ertificate/providers/tresor/certificate_manager.go 60.91% <0.00%> (ø)
pkg/envoy/ads/grpc.go 0.00% <0.00%> (ø)
pkg/envoy/ads/stream.go 0.00% <0.00%> (ø)
pkg/envoy/rds/response.go 29.57% <0.00%> (ø)
pkg/configurator/client.go 84.67% <50.00%> (ø)
pkg/configurator/validating_webhook.go 75.36% <0.00%> (-3.63%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2316bdc...bfdfc0f. Read the comment docs.

Copy link
Contributor

@michelleN michelleN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@nojnhuh nojnhuh merged commit ddcdb0f into openservicemesh:main Jan 26, 2021
@nojnhuh nojnhuh deleted the make-e2e-fix branch January 26, 2021 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants