Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(*): support SMI traffic split v1alpha4 #2870

Closed
wants to merge 1 commit into from

Conversation

michelleN
Copy link
Contributor

@michelleN michelleN commented Mar 15, 2021

WIP

  • updates OSM to support SMI Traffic Split v1alpha4
    which includes HTTPRouteGroup support enabling scenarios
    such as A/B testing and routing based on HTTP attributes

Signed-off-by: Michelle Noorali minooral@microsoft.com

Please mark with X for applicable areas.

-->
Affected area:

  • New Functionality [ ]
  • Documentation [ ]
  • Install [ ]
  • Control Plane [X ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [X ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Demo [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution? No

@michelleN michelleN added the wip Work-in-Progress label Mar 15, 2021
@michelleN michelleN force-pushed the splitv1alpha4 branch 3 times, most recently from a62ef0e to 5770346 Compare March 16, 2021 16:16
@codecov-io
Copy link

Codecov Report

Merging #2870 (5770346) into main (70d6bf2) will increase coverage by 0.20%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
+ Coverage   65.17%   65.38%   +0.20%     
==========================================
  Files         152      152              
  Lines        6904     6904              
==========================================
+ Hits         4500     4514      +14     
+ Misses       2378     2364      -14     
  Partials       26       26              
Flag Coverage Δ
unittests 65.38% <50.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/debugger.go 97.14% <ø> (ø)
pkg/catalog/mock_catalog_generated.go 0.00% <0.00%> (ø)
pkg/debugger/policy.go 53.84% <ø> (ø)
pkg/smi/fake.go 0.00% <ø> (ø)
pkg/smi/mock_meshspec_generated.go 0.00% <0.00%> (ø)
pkg/debugger/mock_debugger_generated.go 56.14% <100.00%> (ø)
pkg/smi/client.go 80.00% <100.00%> (ø)
pkg/injector/health_probes.go 87.17% <0.00%> (ø)
pkg/catalog/xds_certificates.go 90.00% <0.00%> (ø)
pkg/configurator/validating_webhook.go 80.00% <0.00%> (+9.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 70d6bf2...5770346. Read the comment docs.

+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
@bridgetkromhout
Copy link
Contributor

When resolving merge conflicts, please make docs changes in https://github.com/openservicemesh/osm-docs as appropriate - thanks!

@michelleN
Copy link
Contributor Author

Closing as this is now stale.

@michelleN michelleN closed this Oct 4, 2021
@michelleN michelleN deleted the splitv1alpha4 branch October 4, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wip Work-in-Progress
Projects
None yet
3 participants