Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Add SMI Traffic Split (v1alpha4) support in the routes v2 feature #2368

Closed
michelleN opened this issue Jan 25, 2021 · 5 comments
Closed

Add SMI Traffic Split (v1alpha4) support in the routes v2 feature #2368

michelleN opened this issue Jan 25, 2021 · 5 comments
Labels
area/SMI SMI implementation related priority/P2 P2 priority size/L 14 days (~2.5 weeks)
Milestone
vFuture

Comments

@michelleN
Copy link
Contributor

The routes v2 feature is an experimental feature which changes the way we program routes via RDS on the envoy sidecar proxies running next to each application Pod [link to proposal coming]. It currently supports SMI Traffic Access policies. If you enable the feature via the ROUTES_V2 env variable and run this demo, you'll see the once SMI policies are enabled, a source Pod that has been enabled via an SMI Traffic Target object will be able to talk to the destination specified in the policy and a destination will be able to accept requests at certain route configuration (path, method, headers, etc. specified in the SMI TrafficTarget)

This issue is to track the work to support SMI Traffic Split v1alpha4. If an SMI Traffic Split policy is applied, the outbound routes of all relevant client Pod proxies should be updated with the routing configuration specified in the SMI Traffic Split resource.
@snehachhabria snehachhabria mentioned this issue Jan 25, 2021
Closed
@draychev draychev added the size/XL 20 days (4 weeks) label Jan 26, 2021
@snehachhabria snehachhabria changed the title Add SMI Traffic Split support in the routes v2 feature Add SMI Traffic Split (v1alpha4) support in the routes v2 feature Jan 27, 2021
@michelleN michelleN added this to the v0.8.0 milestone Jan 29, 2021
@snehachhabria
Copy link
Contributor

Based on offline discussion this will not be implemented as a part of routesv2 refactor and is an enhancement that will come later. Removing routesv2 label and milestone 0.8

@snehachhabria snehachhabria removed this from the v0.8.0 milestone Feb 10, 2021
@snehachhabria snehachhabria mentioned this issue Feb 10, 2021
Closed
@michelleN michelleN added size/L 14 days (~2.5 weeks) and removed size/XL 20 days (4 weeks) labels Feb 11, 2021
@addozhang
Copy link
Contributor

@snehachhabria does this mean that the split upgreade (to v1alpha3 or v1alpha4) won't be include in milestone 0.8?

@snehachhabria
Copy link
Contributor

@addozhang yes that's right, we will most probably work on this in milestone 0.9

@snehachhabria snehachhabria mentioned this issue Mar 3, 2021
Closed
@draychev draychev added this to the v0.9.0 milestone Mar 5, 2021
@shashankram shashankram mentioned this issue Mar 9, 2021
Closed
@michelleN michelleN added the priority/P2 P2 priority label Mar 9, 2021
@michelleN michelleN self-assigned this Mar 15, 2021
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 15, 2021
feat(*): support SMI traffic split v1alpha4
3ee6fcd 
+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
@michelleN michelleN mentioned this issue Mar 15, 2021
Closed
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 16, 2021
feat(*): support SMI traffic split v1alpha4
c34b676 
+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 16, 2021
feat(*): support SMI traffic split v1alpha4
a62ef0e 
+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 16, 2021
feat(*): support SMI traffic split v1alpha4
5770346 
+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 16, 2021
ref(pkg): update NewRouteWeightedClusters method
265b5ab 
+ now accepts a slice of service.WeightedCluster
+ easier to create RouteWeightedCluster now where there
is more than one backend/weighted cluster
+ prep for openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
@michelleN michelleN mentioned this issue Mar 16, 2021
Merged
michelleN pushed a commit to michelleN/osm that referenced this issue Mar 16, 2021
feat(*): support SMI traffic split v1alpha4
1dc89e8 
+ updates OSM to support SMI Traffic Split v1alpha4
which includes HTTPRouteGroup support enabling scenarios
such as A/B testing and routing based on HTTP attributes

* resolves openservicemesh#2759
* resolves openservicemesh#2368

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
@michelleN michelleN mentioned this issue Mar 31, 2021
Closed
@michelleN michelleN modified the milestones: v0.9.0, v0.10.0 May 6, 2021
@draychev draychev mentioned this issue May 21, 2021
Closed
@michelleN michelleN removed their assignment Jun 14, 2021
@draychev draychev removed this from the v0.10.0 milestone Jun 22, 2021
@draychev draychev added the area/SMI SMI implementation related label Jun 22, 2021
@github-actions
Copy link

This issue will be closed due to a long period of inactivity. If you would like this issue to remain open then please comment or update.

@github-actions github-actions bot added the stale label Feb 25, 2022
@shashankram shashankram added this to the vFuture milestone Feb 25, 2022
@shashankram shashankram removed the stale label Feb 25, 2022
@shashankram
Copy link
Member

Duplicate of #4880

@shashankram shashankram marked this as a duplicate of #4880 Jul 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area/SMI SMI implementation related priority/P2 P2 priority size/L 14 days (~2.5 weeks)
Projects
None yet
Milestone
vFuture
Development

Successfully merging a pull request may close this issue.

feat(*): support SMI traffic split v1alpha4 michelleN/osm
5 participants
@michelleN @addozhang @shashankram @draychev @snehachhabria