This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(pkg): update NewRouteWeightedClusters method #2892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ now accepts a slice of service.WeightedCluster + easier to create RouteWeightedCluster now where there is more than one backend/weighted cluster + prep for openservicemesh#2368 Signed-off-by: Michelle Noorali <minooral@microsoft.com>
Signed-off-by: Michelle Noorali <minooral@microsoft.com>
snehachhabria
approved these changes
Mar 16, 2021
draychev
approved these changes
Mar 16, 2021
| @@ -10,10 +10,15 @@ import ( | |||
| ) | |||
|
|
|||
| // NewRouteWeightedCluster takes a route and weighted cluster and returns a *RouteWeightedCluster | |||
| func NewRouteWeightedCluster(route HTTPRouteMatch, weightedCluster service.WeightedCluster) *RouteWeightedClusters { | |||
| func NewRouteWeightedCluster(route HTTPRouteMatch, weightedClusters []service.WeightedCluster) *RouteWeightedClusters { | |||
| weightedClusterSet := set.NewSet() | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
is more than one backend/weighted cluster
Signed-off-by: Michelle Noorali minooral@microsoft.com
Please mark with X for applicable areas.
-->
Affected area:
Please answer the following questions with yes/no.