This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
identity: Adding K8sServiceAccount.ToServiceIdentity() and ServiceIdentity.ToK8sServiceAccount() #3179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draychev
force-pushed
the
svcidentity-start-w-interfaces_helpers
branch
from
c2cc102 to
8e087e9
Compare
…ntity.ToK8sServiceAccount() Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
draychev
force-pushed
the
svcidentity-start-w-interfaces_helpers
branch
from
8e087e9 to
736fbd1
Compare
This was referenced Apr 15, 2021
Merged
Merged
shashankram
suggested changes
Apr 15, 2021
2 tasks
shashankram
reviewed
Apr 15, 2021
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
shashankram
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
#3182 is tracking the removal of the SDS related code. Looks good otherwise.
eduser25
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a few (not yet used) functions to help with the transition from
K8sServiceAccounttoServiceIdentity(#2218)ServiceIdentity{}.ToK8sServiceAccount()converts aServiceIdentityto aK8sServiceAccount- examples of how this will be used are here Migration path for Service Identity #3170K8sServiceAccount{}.ToServiceIdentity()converts aK8sServiceAccountto aServiceIdentity- examples are also in Migration path for Service Identity #3170ServiceIdentity{}.GetSDSCSecretName()needed to create the string keys used as names for SDS Certs / Secrets - this is going to be used instead ofK8sServiceAccount{}.String()The type changes will arrive with another PR.
No functional code changes in this PR.
This is one of the few steps towards addressing: Use ServiceIdentity type in catalog APIs instead of service.K8sServiceAccount #2218
This is a small chunk from #3170
All PRs in the series: