catalog: Rename ListServiceAccountsForService to ListServiceIdentitiesForService

[draychev]

This PR renames ListServiceAccountsForService to ListServiceIdentitiesForService

The type changes will arrive with another PR.

No functional code changes in this PR.

---

This is one of the few steps towards addressing: Use ServiceIdentity type in catalog APIs instead of service.K8sServiceAccount #2218

---

This is a small chunk from #3170

---

All PRs in the series:

• catalog: Rename ListAllowedInboundServiceAccounts to ListAllowedInboundServiceIdentities catalog: Rename ListAllowedInboundServiceAccounts to ListAllowedInboundServiceIdentities #3176
• catalog: Rename ListAllowedOutboundServiceAccounts to ListAllowedOutboundServiceIdentities catalog: Rename ListAllowedOutboundServiceAccounts to ListAllowedOutboundServiceIdentities #3178
• catalog: Rename ListServiceAccountsForService to ListServiceIdentitiesForService catalog: Rename ListServiceAccountsForService to ListServiceIdentitiesForService #3180
• identity: Adding K8sServiceAccount.ToServiceIdentity() and ServiceIdentity.ToK8sServiceAccount() identity: Adding K8sServiceAccount.ToServiceIdentity() and ServiceIdentity.ToK8sServiceAccount() #3179

[codecov-io]

Codecov Report

Merging #3180 (26eebe4) into main (51c71e5) will increase coverage by 0.17%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##             main    #3180      +/-   ##
==========================================
+ Coverage   66.03%   66.20%   +0.17%     
==========================================
  Files         161      161              
  Lines        7401     7401              
==========================================
+ Hits         4887     4900      +13     
+ Misses       2487     2474      -13     
  Partials       27       27              

Flag	Coverage Δ
unittests	66.20% <55.55%> (+0.17%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/catalog/mock_catalog_generated.go	0.00% <0.00%> (ø)
pkg/kubernetes/client.go	87.31% <ø> (ø)
pkg/kubernetes/mock_controller_generated.go	0.00% <0.00%> (ø)
pkg/kubernetes/types.go	100.00% <ø> (ø)
pkg/catalog/fake.go	71.02% <100.00%> (ø)
pkg/catalog/service.go	90.47% <100.00%> (ø)
pkg/envoy/sds/response.go	89.90% <100.00%> (ø)
pkg/endpoint/providers/kube/client.go	78.00% <0.00%> (-1.00%)	⬇️
pkg/configurator/validating_webhook.go	81.04% <0.00%> (+9.15%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51c71e5...26eebe4. Read the comment docs.