This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
e2e: Moving constants into const.go and out of common.go #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3670 +/- ##
==========================================
- Coverage 67.44% 67.43% -0.02%
==========================================
Files 181 181
Lines 8772 8772
==========================================
- Hits 5916 5915 -1
- Misses 2823 2824 +1
Partials 33 33
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
allenlsy
approved these changes
Jun 28, 2021
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
shalier
approved these changes
Jun 28, 2021
brunoterkaly
pushed a commit
to brunoterkaly/osm
that referenced
this pull request
Jul 3, 2021
nshankar13
pushed a commit
to nshankar13/osm
that referenced
this pull request
Jul 6, 2021
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com> e2e: Moving constants into const.go and out of common.go (openservicemesh#3670) pkg/*: remove unused cacheSynced channel The code waits for caches to sync synchronously using the `WaitForCacheSync()` API. The unused `cacheSynced` channel is not necessary. Signed-off-by: Shashank Ram <shashr2204@gmail.com> feat(upgrade): Add helm hooks to manage crd upgrades This commit allows OSM to manage the lifecyle of CRD's by adding a pre-install and pre-upgrade helm hook to update the CRD's. Part of openservicemesh#3396 Signed-off-by: Sneha Chhabria <snchh@microsoft.com> smi/client: remove unused announcement channel Removes the unused announcement channel which was deprecated in favor of pubsub event framework. Signed-off-by: Shashank Ram <shashr2204@gmail.com> chore(demo): cross service distributed tracing in demo Signed-off-by: Allen Leigh <allenlsy@gmail.com> ref(catalog): improve performance of ListAllowedEndpointsForService() Signed-off-by: Allen Leigh <allenlsy@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all
conststatements into a file namedconst.goand out ofcommon.goReason for this change:
common.gohas around 1600 lines and could benefit from chopping up into smaller chunks.