Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

CRD upgrades #3396

Closed
Tracked by #3019
snehachhabria opened this issue May 24, 2021 · 2 comments · Fixed by #3843
Closed
Tracked by #3019

CRD upgrades #3396

snehachhabria opened this issue May 24, 2021 · 2 comments · Fixed by #3843
Assignees
@snehachhabria
Labels
area/upgrade Upgrade related size/XXL 40 days (2 months)
Milestone
v0.10.0

Comments

@snehachhabria
Copy link
Contributor

snehachhabria commented May 24, 2021 •
edited
Loading

Please describe the Improvement and/or Feature Request
We have two new CRD's in osm, one for policy and the other for meshconfig. We need to come up with a generic way/story to version and upgrade CRD's.

Design Doc : Upgrading CRDs in OSM

Scope (please mark with X where applicable)

  • New Functionality [ ]
  • Install [ ]
  • SMI Traffic Access Policy [ ]
  • SMI Traffic Specs Policy [ ]
  • SMI Traffic Split Policy [ ]
  • Permissive Traffic Policy [ ]
  • Ingress [ ]
  • Egress [ ]
  • Envoy Control Plane [ ]
  • CLI Tool [ ]
  • Metrics [ ]
  • Certificate Management [ ]
  • Sidecar Injection [ ]
  • Logging [ ]
  • Debugging [ ]
  • Tests [ ]
  • CI System [ ]
  • Demo [ ]
  • Project Release [ ]

Possible use cases
@snehachhabria snehachhabria mentioned this issue May 24, 2021
Closed
10 tasks
@draychev draychev added this to the v0.10.0 milestone Jun 2, 2021
@snehachhabria snehachhabria self-assigned this Jun 7, 2021
@snehachhabria snehachhabria mentioned this issue Jun 23, 2021
Closed
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 25, 2021
@snehachhabria
feat(upgrade): Add helm hooks to manage crd upgrades
be85463 
This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jun 26, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 28, 2021
@snehachhabria
feat(upgrade): Add helm hooks to manage crd upgrades
2c91f91 
This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 28, 2021
@snehachhabria
feat(upgrade): Add helm hooks to manage crd upgrades
62a2a17 
This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 29, 2021
@snehachhabria
feat(upgrade): Add helm hooks to manage crd upgrades
371007f 
This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
bec4303 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jun 30, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
0a37bd7 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
This was referenced Jun 30, 2021
Closed
Closed
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
4ec3347 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@draychev draychev mentioned this issue Jun 30, 2021
Closed
17 tasks
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
686593a 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
182d528 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
6acee43 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
2b1945c 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jun 30, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
544acb1 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 1, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
59e2795 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 1, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
7003973 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 1, 2021
@snehachhabria
feat(upgrade): Add a conversion webhook server to OSM control plane
e00353f 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
brunoterkaly pushed a commit to brunoterkaly/osm that referenced this issue Jul 3, 2021
@snehachhabria @brunoterkaly
feat(upgrade): Add helm hooks to manage crd upgrades
6d56947 
This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
nshankar13 pushed a commit to nshankar13/osm that referenced this issue Jul 6, 2021
@draychev @nshankar13
e2e: Turn td.RunLocal() into a variadic function (openservicemesh#3675)
67a98e5 
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>

e2e: Moving constants into const.go and out of common.go (openservicemesh#3670)

pkg/*: remove unused cacheSynced channel

The code waits for caches to sync synchronously
using the `WaitForCacheSync()` API. The unused
`cacheSynced` channel is not necessary.

Signed-off-by: Shashank Ram <shashr2204@gmail.com>

feat(upgrade): Add helm hooks to manage crd upgrades

This commit allows OSM to manage the lifecyle of CRD's by adding a
pre-install and pre-upgrade helm hook to update the CRD's.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>

smi/client: remove unused announcement channel

Removes the unused announcement channel which
was deprecated in favor of pubsub event framework.

Signed-off-by: Shashank Ram <shashr2204@gmail.com>

chore(demo): cross service distributed tracing in demo

Signed-off-by: Allen Leigh <allenlsy@gmail.com>

ref(catalog): improve performance of ListAllowedEndpointsForService()

Signed-off-by: Allen Leigh <allenlsy@gmail.com>
jaellio pushed a commit to jaellio/osm that referenced this issue Jul 12, 2021
@snehachhabria @jaellio
feat(upgrade): Add a conversion webhook server to OSM control plane
45ecba9 
This commit add a conversion webhook server to OSM's control plane. The
purpose to this server is to patch all the CRD's that OSM manages with
the required conversion webhook configuration and to serve the
conversion requests.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 19, 2021
@snehachhabria
feat(upgrade): Add new http server to crd converter
5f0ee04 
Add another http server to the crd converter which servers as the health
endpoint which is used to sync the readiness of osm-controller based on this port.

Update the cleanup hook as pre-delete to ensure propoer deletion order
of CRD's and services via Helm.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jul 19, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 19, 2021
@snehachhabria
feat(upgrade): Add new http server to crd converter
e2ab88a 
Add another http server to the crd converter which servers as the health
endpoint which is used to sync the readiness of osm-controller based on this port.

Update the cleanup hook as pre-delete to ensure propoer deletion order
of CRD's and services via Helm.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 19, 2021
@snehachhabria
feat(upgrade): Add new http server to crd converter
cf8b450 
Add another http server to the crd converter which servers as the health
endpoint which is used to sync the readiness of osm-controller based on this port.

Update the cleanup hook as pre-delete to ensure propoer deletion order
of CRD's and services via Helm.

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 19, 2021
@snehachhabria
feat(upgrade): add handlers for conversion of CRD's in OSM
d652b0b 
This commit adds a handler for all the CRD's that OSM manages. The
actaul business logic for conversion will be added once a CRD has
multiple versions.

Fixs openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jul 19, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 19, 2021
@snehachhabria
feat(upgrade): add handlers for conversion of CRD's in OSM
90d10de 
This commit adds a handler for all the CRD's that OSM manages. The
actaul business logic for conversion will be added once a CRD has
multiple versions.

Fixs openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
This was referenced Jul 19, 2021
Closed
Closed
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 20, 2021
@snehachhabria
feat(upgrade): add handlers for conversion of CRD's in OSM
5301ff6 
This commit adds a handler for all the CRD's that OSM manages. The
actaul business logic for conversion will be added once a CRD has
multiple versions.

Fixs openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 20, 2021
@snehachhabria
feat(upgrade): add handlers for conversion of CRD's in OSM
1623d8a 
This commit adds a handler for all the CRD's that OSM manages. The
actaul business logic for conversion will be added once a CRD has
multiple versions.

Fixs openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria
Copy link
Contributor Author

This feature is currently behind a feature flag enableCRDConverter and no e2e tests have been added as it is blocked on : #3716

@snehachhabria snehachhabria reopened this Jul 20, 2021
@snehachhabria snehachhabria mentioned this issue Jul 21, 2021
Merged
snehachhabria added a commit to snehachhabria/osm that referenced this issue Jul 22, 2021
@snehachhabria
feat(crdUpgrades): enable CRD converter in OSM
4606230 
Enable CRD converter by default as a part of OSM control plane

Part of openservicemesh#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jul 22, 2021
Merged
@snehachhabria
Copy link
Contributor Author

By updating the nodes on CI in PR : #3813 , the CRD converter has now been enabled by default in OSM : #3838

@snehachhabria snehachhabria mentioned this issue Jul 22, 2021
Merged
snehachhabria added a commit to snehachhabria/osm-docs that referenced this issue Jul 23, 2021
@snehachhabria
feat(crdUpgrades): Add CRD upgrade info
d7a2191 
Add information about CRD upgrades to OSM upgrade and uninstall

Part of openservicemesh/osm#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jul 23, 2021
Merged
snehachhabria added a commit to snehachhabria/osm-docs that referenced this issue Jul 23, 2021
@snehachhabria
feat(crdUpgrades): Add CRD upgrade info
be69031 
Add information about CRD upgrades to OSM upgrade and uninstall

Part of openservicemesh/osm#3396

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria mentioned this issue Jul 23, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@snehachhabria snehachhabria

Labels
area/upgrade Upgrade related size/XXL 40 days (2 months)
Projects
None yet
Milestone
v0.10.0
2 participants
@draychev @snehachhabria