Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Update node count for kind cluster on CI #3813

Merged

Conversation

snehachhabria
Copy link
Contributor

@snehachhabria snehachhabria commented Jul 20, 2021

Description:

This commit increase the node count for kind cluster used in the CI.

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

Functional Area
CI System [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

@snehachhabria snehachhabria added the wip Work-in-Progress label Jul 20, 2021
@snehachhabria snehachhabria changed the title Update node for kind cluster on CI Update node count for kind cluster on CI Jul 20, 2021
@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 2 times, most recently from 4346405 to 8c742b8 Compare July 20, 2021 23:24
@codecov-commenter
Copy link

Codecov Report

Merging #3813 (8c742b8) into main (6a113b2) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3813      +/-   ##
==========================================
- Coverage   67.52%   67.51%   -0.01%     
==========================================
  Files         198      198              
  Lines       10926    10926              
==========================================
- Hits         7378     7377       -1     
- Misses       3499     3500       +1     
  Partials       49       49              
Flag Coverage Δ
unittests 67.51% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icate/providers/certmanager/certificate_manager.go 85.91% <0.00%> (-0.71%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a113b2...8c742b8. Read the comment docs.

@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 4 times, most recently from 66c68c5 to c6e56f0 Compare July 21, 2021 01:21
@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 4 times, most recently from 7440f40 to cc49907 Compare July 21, 2021 21:34
@snehachhabria snehachhabria removed the wip Work-in-Progress label Jul 21, 2021
@snehachhabria snehachhabria marked this pull request as ready for review July 21, 2021 22:03
@snehachhabria snehachhabria requested a review from a team as a code owner July 21, 2021 22:03
tests/framework/common.go Outdated Show resolved Hide resolved
tests/framework/common.go Outdated Show resolved Hide resolved
@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 2 times, most recently from 9bbc65c to 11eb3bd Compare July 21, 2021 22:19
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split this change into 2 PRs - 1. update the CI infra, and 2. enable CRD convertor

tests/framework/common.go Outdated Show resolved Hide resolved
@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 5 times, most recently from df97d93 to b8ed86b Compare July 21, 2021 22:42
@snehachhabria snehachhabria force-pushed the increaseKindNodesCI branch 6 times, most recently from 0e11933 to 07fd07b Compare July 22, 2021 18:38
tests/framework/common.go Outdated Show resolved Hide resolved
This commit increase the node count for kind cluster used in the CI.

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria merged commit d1584f1 into openservicemesh:main Jul 22, 2021
@snehachhabria snehachhabria deleted the increaseKindNodesCI branch July 22, 2021 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants