Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing Multi-Arch Support for MCO with Multi-Base Builders #5609

Open
wants to merge 1 commit into
base: openshift-4.18
Choose a base branch
from

Conversation

dkhater-redhat
Copy link

Updated the Machine Config Operator’s build configuration to use both RHEL 9 and RHEL 8 Golang builders, aligning with ART tooling for consistent multi-architecture compatibility. No additional streams or members were needed beyond the dual-builder setup.

See this slack message for more info

Copy link
Contributor

openshift-ci bot commented Oct 31, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ximinhan for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vfreex
Copy link
Contributor

vfreex commented Nov 4, 2024

/hold I will need to check if we can use use ci-* images as the base images for production build. Will come back to you soon.

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 4, 2024
@ashwindasr
Copy link
Contributor

/cherry-pick openshift-4.19

@openshift-cherrypick-robot

@ashwindasr: once the present PR merges, I will cherry-pick it on top of openshift-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick openshift-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@joepvd
Copy link
Contributor

joepvd commented Nov 7, 2024

Context, we're trying to figure out how to make the switch globally in 4.19, here is an option: #5618
Once we have clarity there, we can make things work for 4.18.

@dkhater-redhat
Copy link
Author

gotcha- let me know if you need me to make any changes from my end. thanks for keeping me posted!

@dkhater-redhat
Copy link
Author

hi @joepvd just wanted to check up on this! are there any status updates?

@joepvd
Copy link
Contributor

joepvd commented Nov 25, 2024

Yep, the change made it to 4.19. The go1.23 builder images are now multi arch. The base image and go1.22 images not yet, which I suspect is a temporary issue cause by 4.18 and 4.19 config both pushing to the same places (don't ask, but since branch cut, this should be better).

I hope that tomorrow you're able to use multi images in 4.19.

Unsure when we'll be able to backport tis to 4.18, but that will probably be early January or late December.

If you want to switch to multi builders now in 4.18, I suggest to not change config in ocp-build-data, but only in your Dockerfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants