-
Notifications
You must be signed in to change notification settings - Fork 209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ART-8910: Switch to multi in ci #5618
ART-8910: Switch to multi in ci #5618
Conversation
Once this PR is not draft, might wanna cherry pick to 4.19 |
Fixing tests: openshift-eng/art-tools#1112 |
43f4f95
to
a4fd027
Compare
@joepvd: This pull request references ART-6804 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
upstream_image: registry.ci.openshift.org/ocp/builder:rhel-9-enterprise-base-multi-openshift-{MAJOR}.{MINOR} | ||
upstream_image: registry.ci.openshift.org/ocp/{MAJOR}.{MINOR}:base-rhel9 | ||
|
||
okd_alignment: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we could produce an image based on https://quay.io/centos/centos:stream9 with our https://github.com/openshift-eng/ocp-build-data/blob/openshift-4.18/ci_images/dnf_wrapper.sh script installed on top of it.
For OKD, this base image can't be based on RHEL. It must be based on centos stream. This makes it impossible to build the desired image in OSBS.
okd_alignment only instructs the creation of PRs in openshift/release which build OKD variants of images when PR merge in upstream component repositories.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generated with: ```sh sed -i 's/member: openshift-base-rhel9/member: openshift-enterprise-base-rhel9/' $( git grep -l 'member: openshift-base-rhel9' | grep -v images/openshift-enterprise-base-rhel9.yml) ```
a4fd027
to
f71472b
Compare
@joepvd: This pull request references ART-8910 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Got Justin's approval elsewhere: |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joepvd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6b7738e
into
openshift-eng:openshift-4.19
No description provided.