[WIP] Container-based hermetic Java build #1273
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
force-pushed
the
java-hermetic-builds
branch
from
5718c92 to
9a22b4d
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
java-hermetic-builds
branch
from
6befe3d to
ba2e7e2
Compare
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
java-hermetic-builds
branch
from
9f23927 to
e1355b8
Compare
pierDipi
added a commit
to pierDipi/openshift-knative-hack
that referenced
this pull request
Sep 26, 2024
To support hermetic builds for Java, we will follow the POC here: openshift-knative/eventing-kafka-broker#1273. While this currently doesn't pass the enterprise contract, I've validated that it will in the future with Konflux team here: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1727247236771179 that it will in the future with the addition of `KONFLUX-298`. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
This was referenced Sep 26, 2024
pierDipi
added a commit
to openshift-knative/hack
that referenced
this pull request
Sep 30, 2024
To support hermetic builds for Java, we will follow the POC here: openshift-knative/eventing-kafka-broker#1273. While this currently doesn't pass the enterprise contract, I've validated that it will in the future with Konflux team here: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1727247236771179 that it will in the future with the addition of `KONFLUX-298`. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.