[release-v1.15] Dockerfiles and build changes for hermetic Java builds #1287
Conversation
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
changed the title
|
/test 416-test-conformance-aws-416 |
There was a problem hiding this comment.
What is the reason for not updating openshift/ci-operator/static-images/dispatcher/Dockerfile instead? Is it that we don't have the DEPS_IMAGE in prow-ci?
There was a problem hiding this comment.
Also not sure if this is then detected by konflux-gen (as we need the path to this Dockerfile in the component yaml), because IIRC we get the Konflux components out of the ci-configs images section 🤔
But I probably miss something here
There was a problem hiding this comment.
Also not sure if this is then detected by konflux-gen (as we need the path to this Dockerfile in the component yaml), because IIRC we get the Konflux components out of the ci-configs images section 🤔 But I probably miss something here
Ah found it: https://github.com/openshift-knative/hack/pull/304/files#diff-887f71c262ff6be15cc30b617c94ee85667e3ccd67aa71b7cbacd4470b031716R253.
You updated the konflux-gen for this...
There was a problem hiding this comment.
What is the reason for not updating openshift/ci-operator/static-images/dispatcher/Dockerfile instead? Is it that we don't have the DEPS_IMAGE in prow-ci?
Yes, in prow CI there isn't a way of doing "dependent builds", so we need to have separate Dockerfiles for Konflux
There was a problem hiding this comment.
ah ok. Thanks for clarifying
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
pierDipi
merged commit a290f09
into
openshift-knative:release-v1.15
To support hermetic builds for Java, we will follow the POC here: #1273.
While this currently doesn't pass the enterprise contract, I've validated that it will in the future with Konflux team here: https://redhat-internal.slack.com/archives/C04PZ7H0VA8/p1727247236771179 with the addition of
KONFLUX-298.This brings the dockerfiles and maven build changes from the POC #1273 and they will be used by pipelines introduced in openshift-knative/hack#304