Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.2] Run Eventing midstream periodic jobs only on 4.9 #563

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #556

/assign pierDipi

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/49-so-forward-compatibility-ocp-49 7fc67ef link false /test 49-so-forward-compatibility-ocp-49

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 15, 2022
@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 6a04017 into openshift-knative:release-v1.2 Feb 15, 2022
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
…native#563)

* Using knative/eventing#4815 to override wathola sender transport

* Actual way of replacing an image used for wathola sender

* Reformatting

* Wathola Kafka Sender utilizing plain connection

* Implementing SUT and custom sender

* KafkaSource upgrade test

* Update knative-eventing to 8270497041f2

* Using source config template

* Export kafkaTopicEndpoint to be able to read on TOML

* wathola config reader can read both string and map[string]interface{} for sender.address

* KafkaSource upgrade test works

* Allow to influence Kafka cluster connection details

* Channel tests working

* Removing unused variable name

* Review knative/eventing#5321 changes

* Updates after review of knative/eventing#4815

* Use latest integration/eventing-sandbox/eventing-kafka/pr-563 commit

* Update deps

* Update deps

* Refactor after review

* Shorten the TypeMeta field

* Tweak the merge slices func after review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants