Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][DNM] Save and apply release image signatures #1019

Closed
wants to merge 1 commit into from

Conversation

stbenjam
Copy link
Member

@stbenjam stbenjam commented Apr 18, 2020

openshift/oc#343 now requires you to do something about the eventual release image signatures. OpenShift CI is now failing:

+(./04_setup_ironic.sh:68): main(): oc adm release mirror --insecure=true -a combined-pullsecret--gyUsq8fVYL --from registry.svc.ci.openshift.org/ci-op-hmxpdxpw/release@sha256:7d9cc5731a84efab3c59fe66a81a66ec1d3e386183b383f905d0efc71dd6f161 --to-release-image virthost.ostest.test.metalkube.org:5000/localimages/local-release-image:7d9cc5731a84efab3c59fe66a81a66ec1d3e386183b383f905d0efc71dd6f161 --to virthost.ostest.test.metalkube.org:5000/localimages/local-release-image
error: if --to-dir and --apply-release-image-signature are not specified, --release-image-signature-to-dir must be used to specify a directory to export the signature

Unfortunately oc explodes when you give the release-image-signature-to-dir on older releases, so we again need to be aware of the oc version to give the option or not.

This whole change is problematic to deal with:

  1. oc version --client -o json doesn't give you an easily machine comparable version
  2. Even if we parse the releaseClientVersion, this isn't in 4.3 or 4.4 I think. The format from oc version has changed several times, and relying on it has broken us before
  3. CI doesn't even tell us what OCP release we're using as everything is versioned as 0.0.1...

Will continue investigating on Monday. I filed https://bugzilla.redhat.com/show_bug.cgi?id=1825565 with a suggestion of exporting the config map to $PWD if no option is specified, instead of exploding.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign stbenjam
You can assign the PR to them by writing /assign @stbenjam in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stbenjam
Copy link
Member Author

At some point we'll need to deal with release signatures, but oc is going to change to not require release-signature related options to preserve backwards compatibility. openshift/oc#392

/close

@openshift-ci-robot
Copy link

@stbenjam: Closed this PR.

In response to this:

At some point we'll need to deal with release signatures, but oc is going to change to not require release-signature related options to preserve backwards compatibility. openshift/oc#392

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stbenjam stbenjam deleted the oc-breakage branch April 20, 2020 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants