[WIP][DNM] Save and apply release image signatures #1019
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openshift/oc#343 now requires you to do something about the eventual release image signatures. OpenShift CI is now failing:
Unfortunately
oc
explodes when you give the release-image-signature-to-dir on older releases, so we again need to be aware of theoc
version to give the option or not.This whole change is problematic to deal with:
oc version --client -o json
doesn't give you an easily machine comparable versionreleaseClientVersion
, this isn't in 4.3 or 4.4 I think. The format fromoc version
has changed several times, and relying on it has broken us beforeWill continue investigating on Monday. I filed https://bugzilla.redhat.com/show_bug.cgi?id=1825565 with a suggestion of exporting the config map to $PWD if no option is specified, instead of exploding.