Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running auxiliary containers with maximum priveleges #1606

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dtantsur
Copy link
Member

None of the Metal3 components actually require --privileged.
Instead, disable the SELinux isolation to allow the containers
to mount host directories.

Also don't expose sushy-tools and vbmc to the host networking.

Copy link

openshift-ci bot commented Nov 23, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from dtantsur. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dtantsur dtantsur force-pushed the no-privileged branch 2 times, most recently from 629c0af to 3ce3905 Compare November 23, 2023 15:22
None of the Metal3 components actually require --privileged.
Instead, disable the SELinux isolation to allow the containers
to mount host directories.

Also don't expose vbmc to the host networking.

For this all to work, stop using a pod for these containers.
I'm not sure why we even do that in the first place.
@elfosardo
Copy link
Member

/retest

1 similar comment
@dtantsur
Copy link
Member Author

/retest

Copy link

openshift-ci bot commented Nov 24, 2023

@dtantsur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-dualstack 819abff link false /test e2e-metal-ipi-ovn-dualstack
ci/prow/e2e-metal-ipi-ovn-ipv6 819abff link true /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-metal-ipi-bm-bond 819abff link false /test e2e-metal-ipi-bm-bond
ci/prow/e2e-metal-ipi-serial-ipv4 819abff link true /test e2e-metal-ipi-serial-ipv4
ci/prow/e2e-metal-ipi-serial-ovn-ipv6 819abff link false /test e2e-metal-ipi-serial-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants