Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

METAL-1087: Soft pin yq version #1668

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

elfosardo
Copy link
Member

@elfosardo elfosardo commented Jun 21, 2024

Also install it early to avoid installing it twice

@openshift-ci openshift-ci bot requested review from celebdor and sadasu June 21, 2024 09:19
@elfosardo elfosardo changed the title Install yq early and pin it Avoid installing yq twice Jun 21, 2024
@elfosardo
Copy link
Member Author

/retest
not sure what happened here but it doesn't look related

@elfosardo
Copy link
Member Author

/retest

@dtantsur
Copy link
Member

/approve

Copy link

openshift-ci bot commented Jun 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dtantsur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 24, 2024
@elfosardo
Copy link
Member Author

/retest

1 similar comment
@elfosardo
Copy link
Member Author

/retest

@elfosardo
Copy link
Member Author

/retest

@iurygregory
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 27, 2024
@rhjanders
Copy link

/test e2e-metal-ipi-serial-ipv4

@elfosardo
Copy link
Member Author

/retest
failure not related to this patch

@elfosardo
Copy link
Member Author

/retest

4 similar comments
@elfosardo
Copy link
Member Author

/retest

@elfosardo
Copy link
Member Author

/retest

@elfosardo
Copy link
Member Author

/retest

@elfosardo
Copy link
Member Author

/retest

@elfosardo
Copy link
Member Author

/retest
we're past the timeout issue

@elfosardo
Copy link
Member Author

/retest

1 similar comment
@elfosardo
Copy link
Member Author

/retest

Also install it early and pin its version
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2024
@elfosardo
Copy link
Member Author

/retest

1 similar comment
@elfosardo
Copy link
Member Author

/retest

@iurygregory
Copy link
Contributor

/test e2e-metal-ipi-serial-ipv4

@iurygregory
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@rhjanders
Copy link

/test e2e-metal-ipi-serial-ipv4

@openshift-merge-bot openshift-merge-bot bot merged commit 0da9412 into openshift-metal3:master Jul 15, 2024
12 checks passed
@elfosardo elfosardo changed the title Avoid installing yq twice METAL-1087: Avoid installing yq twice Jul 16, 2024
@elfosardo elfosardo changed the title METAL-1087: Avoid installing yq twice METAL-1087: Soft pin yq version Jul 16, 2024
@elfosardo
Copy link
Member Author

/jira refresh

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants