OCM-11703 | Update provider flag check #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckandag
changed the title
ckandag
reviewed
Oct 17, 2024
ckandag
reviewed
Oct 17, 2024
|
please review err msg , looks good otherwise |
ckandag
approved these changes
Oct 17, 2024
ckandag
added a commit
that referenced
this pull request
Oct 25, 2024
-8b70707 Release v0.1.76 (#674) -2ef1e1d Update Konflux references to 67f0290 (#676) -c63247f Show all WIF configs in interactive dropdown (#677) -f1d29bc adding interactive move for WifConfig creation (#675) -1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678) -d0b58b4 Do not default GCP authentication type (#679) -db35759 improve psc cli UX (#681) -862b072 OCM-11993 | Describe cluster shows WifConfig data (#683) -4053505 Add PSC-XPN to cluster description (#685) -0c456f8 OCM-10728 | interface improvements (#686) -1e27ded Add more descriptions to WIF resources (#684) -cdf6466 update filenames in konflux release container (#687) -010573f remove version from shasum (#688)
Merged
renan-campos
pushed a commit
that referenced
this pull request
Oct 25, 2024
-8b70707 Release v0.1.76 (#674) -2ef1e1d Update Konflux references to 67f0290 (#676) -c63247f Show all WIF configs in interactive dropdown (#677) -f1d29bc adding interactive move for WifConfig creation (#675) -1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678) -d0b58b4 Do not default GCP authentication type (#679) -db35759 improve psc cli UX (#681) -862b072 OCM-11993 | Describe cluster shows WifConfig data (#683) -4053505 Add PSC-XPN to cluster description (#685) -0c456f8 OCM-10728 | interface improvements (#686) -1e27ded Add more descriptions to WIF resources (#684) -cdf6466 update filenames in konflux release container (#687) -010573f remove version from shasum (#688)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/OCM-11703
Require provider, do not default to AWS, and check for provider-specific flags