Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not default GCP authentication type #679

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Do not default GCP authentication type #679

merged 1 commit into from
Oct 22, 2024

Conversation

JakobGray
Copy link
Contributor

@JakobGray JakobGray commented Oct 17, 2024 •
edited
Loading

Issue: https://issues.redhat.com/browse/OCM-11699

  • Require gcp authentication method be clear based on input
  • Address issue where no means of authentication (or two conflicting options) are provided in non-interactive mode
  • Cover invalid scenarios where authentication method is set in non-ccs mode
ocm create cluster --ccs --provider=gcp --dry-run=true jjjj
Error: either wif-config or GCP service account file must be specified

ocm create cluster --ccs --provider=gcp --dry-run=true jjjj --wif-config=test --service-account-file=key.json
Error: can't use both wif-config and GCP service account file at the same time

@ckandag ckandag merged commit d0b58b4 into openshift-online:main Oct 22, 2024
4 of 5 checks passed
@JakobGray JakobGray deleted the OCM-11699 branch October 23, 2024 12:17
ckandag added a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2
021835c 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
@ckandag ckandag mentioned this pull request Oct 25, 2024
Merged
renan-campos pushed a commit that referenced this pull request Oct 25, 2024
@ckandag
Release v1.0.2 (#689)
c2a39c6 
-8b70707 Release v0.1.76 (#674)
-2ef1e1d Update Konflux references to 67f0290 (#676)
-c63247f Show all WIF configs in interactive dropdown (#677)
-f1d29bc adding interactive move for WifConfig creation (#675)
-1382a6c Require provider, do not default to AWS, and check for provider-specific flags (#678)
-d0b58b4 Do not default GCP authentication type (#679)
-db35759 improve psc cli UX (#681)
-862b072 OCM-11993 | Describe cluster shows WifConfig data (#683)
-4053505 Add PSC-XPN to cluster  description (#685)
-0c456f8 OCM-10728 | interface improvements (#686)
-1e27ded Add more descriptions to WIF resources (#684)
-cdf6466 update filenames in konflux release  container (#687)
-010573f remove version from shasum (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckandag ckandag ckandag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JakobGray @ckandag