Use the beta by default in OpenShift Pipelines

[Roming22]

No description provided.

[Roming22]

/test pipeline-service-test

[gabemontero]

/lgtm

fingers crossed (seems likely) this addresses redhat-appstudio/infra-deployments#1776 (comment)

@Michkov FYI

[Roming22]

/test pipeline-service-test

[Roming22]

I can see the following error in the operator's pod logs:

{"level":"error","logger":"tekton-operator-lifecycle","caller":"controller/controller.go:566","msg":"Reconcile error","commit":"1d0fb8d","knative.dev/pod":"openshift-pipelines-operator-5bc7b9c965-r4tfb","knative.dev/controller":"github.com.tektoncd.operator.pkg.reconciler.shared.tektonconfig.Reconciler","knative.dev/kind":"operator.tekton.dev.TektonConfig","knative.dev/traceid":"039e1e02-3ba0-4b9b-b847-55b4c72dd2d3","knative.dev/key":"config","duration":0.046486388,"error":"failed to set finalizers: admission webhook \"validation.webhook.operator.tekton.dev\" denied the request: validation failed: invalid value: beta: spec.pipeline.enable-api-fields","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/github.com/tektoncd/operator/vendor/knative.dev/pkg/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/github.com/tektoncd/operator/vendor/knative.dev/pkg/controller/controller.go:543\nknative.dev/pkg/controller.(*Impl).RunContext.func3\n\t/go/src/github.com/tektoncd/operator/vendor/knative.dev/pkg/controller/controller.go:491"} 

I thought I followed [the doc|https://tekton.dev/docs/pipelines/additional-configs/#beta-features]. Looking into the problem.

[adambkaplan]

Let's be careful about what "beta" means here - @vdemeester I think this might be a source of confusion for teams migrating to the v1 API. I don't think this means "enable the v1beta1 API" - that is still there and isn't going away. That API version, however, might have breaking changes from 1.9 to 1.10...

[ramessesii2]

/test pipeline-service-test

[vdemeester]

Let's be careful about what "beta" means here - @vdemeester I think this might be a source of confusion for teams migrating to the v1 API. I don't think this means "enable the v1beta1 API" - that is still there and isn't going away. That API version, however, might have breaking changes from 1.9 to 1.10...

I didn't really understand everything, but this value is coming from upstream tektoncd/pipeline, and it is indeed confusing, see tektoncd/pipeline#6592 (comment). It definitely doesn't mean "enable the v1beta1 API" indeed, and needs to be refined. But, as pointed out in the comment, having it to stable comes with a very very very confusing behavior when migrating things from v1beta1 to v1.

This change will need a 1.9.3 or 1.10.1 to be released before being successful 😅

[Roming22]

/retest