Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pipeline-service #1776

Closed
wants to merge 1 commit into from
Closed

Update pipeline-service #1776

wants to merge 1 commit into from

Conversation

Roming22
Copy link
Member

@Roming22 Roming22 commented May 3, 2023

  • Deploy downstream images for pipelines-as-code and tekton-chains (ESS remediation).

@openshift-ci openshift-ci bot requested review from Mo3m3n and ramessesii2 May 3, 2023 19:34
@openshift-ci openshift-ci bot added the approved label May 3, 2023
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
@openshift-ci openshift-ci bot removed the lgtm label May 3, 2023
@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 3, 2023
@Roming22
Copy link
Member Author

Roming22 commented May 3, 2023

/test appstudio-hac-e2e-tests

@Michkov
Copy link
Contributor

Michkov commented May 4, 2023

https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/redhat-appstudio_infra-deployments/1776/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1653861200703787008/artifacts/appstudio-e2e-tests/redhat-appstudio-hypershift-gather/artifacts/pods/pipelines-as-code_pipelines-as-code-controller-6f6d6464d7-2qhtv_pac-controller.log
{"severity":"ERROR","timestamp":"2023-05-03T21:15:52.898049112Z","logger":"pipelinesascode","caller":"events/emit.go:45","message":"PipelineRun test-mvp-component-ccge-on-pull-request- has failed: creating pipelinerun test-mvp-component-ccge-on-pull-request- in mvp-demo-dev-namespace-voky-tenant has failed: admission webhook \"validation.webhook.pipeline.tekton.dev\" denied the request: validation failed: must not set the field(s): spec.pipelineSpec.finally[0].taskref.params, spec.pipelineSpec.finally[0].taskref.resolver, spec.pipelineSpec.finally[1].taskref.params, spec.pipelineSpec.finally[1].taskref.resolver, spec.pipelineSpec.tasks[0].taskref.params, spec.pipelineSpec.tasks[0].taskref.resolver, spec.pipelineSpec.tasks[10].taskref.params, spec.pipelineSpec.tasks[10].taskref.resolver, spec.pipelineSpec.tasks[11].taskref.params, spec.pipelineSpec.tasks[11].taskref.resolver, spec.pipelineSpec.tasks[1].taskref.params, spec.pipelineSpec.tasks[1].taskref.resolver, spec.pipelineSpec.tasks[2].taskref.params, spec.pipelineSpec.tasks[2].taskref.resolver, spec.pipelineSpec.tasks[3].taskref.params, spec.pipelineSpec.tasks[3].taskref.resolver, spec.pipelineSpec.tasks[4].taskref.params, spec.pipelineSpec.tasks[4].taskref.resolver, spec.pipelineSpec.tasks[5].taskref.params, spec.pipelineSpec.tasks[5].taskref.resolver, spec.pipelineSpec.tasks[6].taskref.params, spec.pipelineSpec.tasks[6].taskref.resolver, spec.pipelineSpec.tasks[7].taskref.params, spec.pipelineSpec.tasks[7].taskref.resolver, spec.pipelineSpec.tasks[8].taskref.params, spec.pipelineSpec.tasks[8].taskref.resolver, spec.pipelineSpec.tasks[9].taskref.params, spec.pipelineSpec.tasks[9].taskref.resolver ","provider":"github","event-id":"ae8d6790-e9f7-11ed-93e7-655633528013","event-sha":"bdf50475e733ecec924661cfedf70f5f3f89c38a","event-type":"pull_request","stacktrace":"github.com/openshift-pipelines/pipelines-as-code/pkg/events.(*EventEmitter).EmitMessage\n\t/go/src/github.com/openshift-pipelines/pipelines-as-code/pkg/events/emit.go:45\ngithub.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode.(*PacRun).Run.func1\n\t/go/src/github.com/openshift-pipelines/pipelines-as-code/pkg/pipelineascode/pipelineascode.go:79"}

The pull-request which failed -> redhat-appstudio-qe/hacbs-test-project#1732 , that's pipelineRun in v1beta1 version which is working without issue with older pipeline-as-code.

This was referenced May 4, 2023
Merged
Merged
@openshift-ci openshift-ci bot removed the lgtm label May 5, 2023
gabemontero
gabemontero approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@gabemontero gabemontero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 5, 2023
@Roming22
Copy link
Member Author

Roming22 commented May 5, 2023

/retest

@Roming22
Copy link
Member Author

Roming22 commented May 5, 2023

/test appstudio-e2e-tests

3 similar comments
@Roming22
Copy link
Member Author

Roming22 commented May 5, 2023

/test appstudio-e2e-tests

@Roming22
Copy link
Member Author

Roming22 commented May 5, 2023

/test appstudio-e2e-tests

@Roming22
Copy link
Member Author

Roming22 commented May 8, 2023

/test appstudio-e2e-tests

@flacatus
Copy link
Contributor

flacatus commented May 8, 2023

/test all

1 similar comment
@Roming22
Copy link
Member Author

Roming22 commented May 9, 2023

/test all

@openshift-ci openshift-ci bot removed the lgtm label May 9, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 9, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gabemontero, Roming22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 9, 2023
@Roming22
Copy link
Member Author

Roming22 commented May 9, 2023

/test all

@openshift-ci openshift-ci bot removed the lgtm label May 10, 2023
@openshift-ci
Copy link

openshift-ci bot commented May 10, 2023

New changes are detected. LGTM label has been removed.

@gabemontero
Copy link
Contributor

mvp demo failed yet again @Roming22 (along with some other failures I'm classifying as flakes for now since we have not seen them previously)

 • [FAILED] [900.904 seconds]
[mvp-demo-suite MVP Demo tests] MVP Demo Chapter 2 - advanced pipeline, JVM rebuild, successful release [It] Release PipelineRun should eventually succeed and associated Release should be marked as succeeded [mvp-demo, mvp-demo-chapter-2]
/tmp/tmp.XwZZzgNqEA/tests/mvp-demo/mvp-demo.go:450

per slack/standup discussions, I'm trying to repo locally to confirm / facilitate debug.
I'll also try mvp-demo against main branch to confirm/deny if the failure is happening there.

@flacatus
Copy link
Contributor

/test all

1 similar comment
@xinredhat
Copy link
Member

/test all

@gabemontero gabemontero mentioned this pull request May 11, 2023
Merged
@Roming22
Update pipeline-service
97fe75b 
* Deploy downstream images for pipelines-as-code and tekton-chains
  (ESS remediation).

Signed-off-by: Romain Arnaud <rarnaud@redhat.com>
@gabemontero
Copy link
Contributor

unless konflux-ci/e2e-tests#515 merges before the e2e piece of https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_infra-deployments/1776/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1656761058292928512 we'll need at least one more retest on this

@gabemontero
Copy link
Contributor

gabemontero commented May 11, 2023 •
edited
Loading

test has started in https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/redhat-appstudio_infra-deployments/1776/pull-ci-redhat-appstudio-infra-deployments-main-appstudio-e2e-tests/1656761058292928512 so we'll need at least 1 more retest after this current run fails

unless I have to rebase because #1803 merges (it is in the merge pool as I type)

@openshift-ci
Copy link

openshift-ci bot commented May 11, 2023

@Roming22: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/appstudio-hac-e2e-tests 97fe75b link false /test appstudio-hac-e2e-tests
ci/prow/appstudio-e2e-tests 97fe75b link true /test appstudio-e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gabemontero
Copy link
Contributor

I'll rebase / retest if konflux-ci/e2e-tests#515 merges

@ramessesii2
Copy link
Member

Closing in favor of #1811

@gabemontero
Copy link
Contributor

Just to be clear, #1811 is bringing the change in default tekton SA's, and for now is skipping the switch from the upstream to downstream images for chains and PaC.

Both goals are still needed sooner rather than later. Hopefully we can sort out the EC related changes need to make the downstream images work in e2e's in parallel, and then pivot right back to using the downstream images after #1811 merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero gabemontero approved these changes

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

@Mo3m3n Mo3m3n Awaiting requested review from Mo3m3n

@ramessesii2 ramessesii2 Awaiting requested review from ramessesii2

Assignees

@gabemontero gabemontero

Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Roming22 @gabemontero @Michkov @flacatus @xinredhat @ramessesii2