Skip to content

Migrate DeepCopy and Compatibility gen to Gengo v2 #1776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 4 commits into from
Mar 25, 2025
Merged

Migrate DeepCopy and Compatibility gen to Gengo v2 #1776

openshift-merge-bot merged 4 commits into from
Mar 25, 2025

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Feb 23, 2024 •
edited
Loading

Working on moving our generators to the upstream WIP gengo v2 project.

Current issues I need to work through:

  • Gengo v2 has no verify-only option which we rely on in deepcopy, prerelease-lifecycle generators
  • OpenAPI WIP branch is not up to date with K/K PR, so cannot integrate that yet
  • Pre-release lifecycle gen not integrated with codegen, it would be easier to manage if it were, very black box and only working on apps API group right now
  • Have a WIP proto integration to codegen that wasn't working in non GOPATH, may work now
  • Check if deepcopy etc works correctly in non-gopath

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 23, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 23, 2024

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Mar 8, 2024

/test verify

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 11, 2024
@openshift-bot
Copy link

openshift-bot commented Jun 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Jun 18, 2024

/remove-lifecycle stale

I need to come back to this

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@atiratree atiratree mentioned this pull request Aug 5, 2024
Merged
4 tasks
@dusk125 dusk125 mentioned this pull request Nov 13, 2024
Merged
@openshift-bot
Copy link

openshift-bot commented Nov 14, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 14, 2024
@openshift-bot
Copy link

openshift-bot commented Jan 4, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 4, 2025
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Jan 6, 2025

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jan 6, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 6, 2025
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Jan 7, 2025

/test verify

@JoelSpeed JoelSpeed changed the title WIP: Migrate gengo v2 Migrate DeepCopy and Compatibility gen to Gengo v2 Mar 25, 2025
@JoelSpeed JoelSpeed marked this pull request as ready for review March 25, 2025 13:46
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 25, 2025
@openshift-ci openshift-ci bot requested review from bparees and cheesesashimi March 25, 2025 13:47
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025 •
edited
Loading

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-serial-techpreview 12e546a link true /test e2e-aws-serial-techpreview
ci/prow/e2e-upgrade 12e546a link true /test e2e-upgrade
ci/prow/e2e-aws-serial 12e546a link true /test e2e-aws-serial
ci/prow/e2e-aws-ovn-techpreview 12e546a link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-ovn-hypershift 12e546a link true /test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade-minor 12e546a link true /test e2e-upgrade-minor
ci/prow/e2e-aws-ovn 12e546a link true /test e2e-aws-ovn
ci/prow/minor-e2e-upgrade-minor 12e546a link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Mar 25, 2025

/skip

everettraven
everettraven approved these changes Mar 25, 2025
View reviewed changes
Copy link
Contributor

@everettraven everettraven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Mar 25, 2025

/label acknowledge-critical-fixes-only

This only affects code generation within the repo, which is a trivial change

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 25, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 0f14a21 into openshift:master Mar 25, 2025
12 checks passed
@openshift-bot
Copy link

openshift-bot commented Mar 25, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.20.0-202503251712.p0.g0f14a21.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@everettraven everettraven everettraven approved these changes

@bparees bparees Awaiting requested review from bparees

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

Assignees

@everettraven everettraven

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoelSpeed @openshift-bot @everettraven @openshift-merge-robot