Skip to content

WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 #1983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 20 commits into from
Oct 1, 2024
Merged

WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 #1983

openshift-merge-bot merged 20 commits into from
Oct 1, 2024

Conversation

@atiratree
Copy link
Member

@atiratree atiratree commented Aug 1, 2024 •
edited
Loading

TODO:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 1, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

  • WIP: make update not passing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

Hello @atiratree! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 1, 2024
@openshift-ci openshift-ci bot requested review from deads2k and soltysh August 1, 2024 18:53
@atiratree atiratree mentioned this pull request Aug 2, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member Author

atiratree commented Aug 5, 2024

The PR passes make update so we can use it as a dependency for now, but there are still TODOs which are mentioned in the description.

@atiratree
Copy link
Member Author

atiratree commented Aug 5, 2024

/test verify-client-go

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 5, 2024

@atiratree: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test build
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-hypershift
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-aws-serial-techpreview
  • /test e2e-upgrade
  • /test e2e-upgrade-minor
  • /test images
  • /test integration
  • /test unit
  • /test verify
  • /test verify-client-go
  • /test verify-crd-schema
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-azure
  • /test e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-e2e-upgrade-minor
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps

In response to this:

/retest verify-client-go

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 6, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2024
@atiratree atiratree force-pushed the bump-1.31 branch 3 times, most recently from c3fd90e to f1867d7 Compare August 6, 2024 18:45
@atiratree
Copy link
Member Author

atiratree commented Aug 6, 2024

/retest

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 9, 2024 •
edited by openshift-ci bot
Loading

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

In response to this:

TODO:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
atiratree and others added 17 commits October 1, 2024 13:29
@atiratree
bump(k8s): go mod vendor and tools: go mod vendor
9104a79
@atiratree
update openapi generator to use k8s.io/gengo/v2
0083ce5
@atiratree
make apimachinery/pkg/version/ optional dependency for openapi genera…
6a4ce93 
…tion
@atiratree
bump(k8s): tools: make k8s.io/gengo/v2 explicit in go.mod
b54bbbb
@atiratree
bump(k8s): make update-openapi
5d37436
@atiratree
fix update-protobuf.sh script
d9cd7d8
@atiratree
bump(k8s): make update-protobuf
16bf140
@JoelSpeed @atiratree
Update pre-release lifecycle gen script
53d0a74
@atiratree
fix machine types for update-codegen-crds.sh
78c5267
@atiratree
./hack/update-codegen-crds.sh
10303fe
@atiratree
make update
fd90814
@atiratree
consider .spec.authoritativeAPI defaulting in the machine integration…
a648274 
… tests

- the field should be present and default to MachineAPI when MachineAPIMigration feature gate is on (CustomNoUpgrade ATM)
- the field should not be present in other cases
@atiratree
fix tests for StableConfigType by reacting to a newly required field …
a9a0705 
…spec.celUnion.type
@atiratree
fix verify-prerelease-lifecycle-gen.sh
57645f3 
--verify-only option has been removed, so use git diff instead
@atiratree
add new image fs type
e8a7740
@atiratree
fix MustHaveStatus error for networks.operator.openshift.io
c40ad4a
@atiratree
./hack/update-payload-crds.sh
1354e87
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@atiratree
Copy link
Member Author

atiratree commented Oct 1, 2024

verify failed because we need to react to https://github.com/openshift/api/pull/2027/files that merged in the meantime and regenerate the CRDs

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 1, 2024

/lgtm
/override ci/prow/verify-client-go
/override ci/prow/verify-crd-schema

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-client-go, ci/prow/verify-crd-schema

In response to this:

/lgtm
/override ci/prow/verify-client-go
/override ci/prow/verify-crd-schema

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e415140 into openshift:master Oct 1, 2024
This was referenced Oct 1, 2024
Closed
Merged
Merged
@openshift-bot
Copy link

openshift-bot commented Oct 1, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410011141.p0.ge415140.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoelSpeed JoelSpeed JoelSpeed left review comments

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@atiratree @openshift-ci-robot @JoelSpeed @openshift-bot @openshift-merge-robot