Skip to content

Conversation

@atiratree
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 5, 2024

@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.18" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
@openshift-ci openshift-ci bot requested review from JoelSpeed and soltysh August 5, 2024 16:58
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@atiratree atiratree changed the title [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.0 [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 Sep 20, 2024
@atiratree atiratree force-pushed the bump-1.31 branch 4 times, most recently from c8fae79 to ae62238 Compare September 26, 2024 18:15
@perdasilva
Copy link

perdasilva commented Sep 27, 2024

@atiratree can we take this out of WIP? I see, you're still waiting on openshift/api
Though, I also see there's a verify client-go job. Is this the right order? api -> client-go -> library-go?

or can we merge this one to unblock api then update/merge library-go?

@atiratree atiratree changed the title [WIP] WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 WRKLDS-1449: bump(k8s): update k8s.io/* dependencies to v1.31.1 Oct 1, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 1, 2024
@atiratree
Copy link
Member Author

Though, I also see there's a verify client-go job. Is this the right order? api -> client-go -> library-go?

@perdasilva yup, that is the right order

we have just merged openshift/api#1983 and continue with this one

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, bertinatto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit da6d55e into openshift:master Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants