Skip to content

OCPCLOUD-2561: Remove CloudProviderExternal feature gates #1780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2024
Merged

OCPCLOUD-2561: Remove CloudProviderExternal feature gates #1780

merged 1 commit into from
Aug 17, 2024

Conversation

@JoelSpeed
Copy link
Contributor

@JoelSpeed JoelSpeed commented Mar 1, 2024

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2024 •
edited by openshift-ci bot
Loading

@JoelSpeed: This pull request references OCPCLOUD-2514 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

These feature gates were promoted to GA in 4.15, the code that observes them was in library go and vendored into 4 other operators, once the following 4 PRs are merged, we no longer require these feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

Hello @JoelSpeed! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 1, 2024
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 12, 2024
@JoelSpeed JoelSpeed marked this pull request as ready for review March 12, 2024 16:59
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@openshift-ci openshift-ci bot requested review from deads2k and mfojtik March 12, 2024 17:03
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 12, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Mar 13, 2024

Per conversation in slack, holding this until further notice (perhaps 4.18 open)

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 13, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 14, 2024
@JoelSpeed JoelSpeed changed the title OCPCLOUD-2514: Remove CloudProviderExternal feature gates OCPCLOUD-2561: Remove CloudProviderExternal feature gates Mar 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 14, 2024 •
edited by openshift-ci bot
Loading

@JoelSpeed: This pull request references OCPCLOUD-2561 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

These feature gates were promoted to GA in 4.15, the code that observes them was in library go and vendored into 4 other operators, once the following 4 PRs are merged, we no longer require these feature gates

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

openshift-bot commented Jun 18, 2024

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Jun 18, 2024

/remove-lifecycle stale

Keeping this open as it's still something we intend to do, later this year

@openshift-ci openshift-ci bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 18, 2024
@machine424 machine424 mentioned this pull request Aug 9, 2024
Merged
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Aug 15, 2024

/hold cancel

I think we are good to remove these now

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 15, 2024
@JoelSpeed
Copy link
Contributor Author

JoelSpeed commented Aug 15, 2024

/test minor-e2e-upgrade-minor

@sdodson
Copy link
Member

sdodson commented Aug 16, 2024

/lgtm
/retest-required

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 16, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Aug 16, 2024

/test e2e-upgrade-minor

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024

@sdodson: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test build
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-hypershift
  • /test e2e-aws-ovn-techpreview
  • /test e2e-aws-serial
  • /test e2e-aws-serial-techpreview
  • /test e2e-upgrade
  • /test images
  • /test integration
  • /test minor-e2e-upgrade-minor
  • /test minor-images
  • /test unit
  • /test verify
  • /test verify-client-go
  • /test verify-crd-schema
  • /test verify-deps

The following commands are available to trigger optional jobs:

  • /test e2e-azure
  • /test e2e-gcp
  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-api-master-build
  • pull-ci-openshift-api-master-e2e-aws-ovn
  • pull-ci-openshift-api-master-e2e-aws-ovn-hypershift
  • pull-ci-openshift-api-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-api-master-e2e-aws-serial
  • pull-ci-openshift-api-master-e2e-aws-serial-techpreview
  • pull-ci-openshift-api-master-e2e-azure
  • pull-ci-openshift-api-master-e2e-gcp
  • pull-ci-openshift-api-master-e2e-upgrade
  • pull-ci-openshift-api-master-images
  • pull-ci-openshift-api-master-integration
  • pull-ci-openshift-api-master-minor-e2e-upgrade-minor
  • pull-ci-openshift-api-master-minor-images
  • pull-ci-openshift-api-master-unit
  • pull-ci-openshift-api-master-verify
  • pull-ci-openshift-api-master-verify-client-go
  • pull-ci-openshift-api-master-verify-crd-schema
  • pull-ci-openshift-api-master-verify-deps

In response to this:

/test e2e-upgrade-minor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 16, 2024 •
edited
Loading

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-upgrade-minor 227592a link true /test e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 16, 2024

/retest-required

Remaining retests: 0 against base HEAD 65532e7 and 2 for PR HEAD 227592a in total

@openshift-merge-bot openshift-merge-bot bot merged commit 2c10e58 into openshift:master Aug 17, 2024
@openshift-bot
Copy link

openshift-bot commented Aug 17, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202408170514.p0.g2c10e58.assembly.stream.el9.
All builds following this will include this PR.

@JoelSpeed JoelSpeed deleted the remove-cloud-fg branch August 21, 2024 15:23
rvanderp3 added a commit to rvanderp3/machine-config-operator that referenced this pull request Sep 6, 2024
@rvanderp3
drop feature gates dropped in openshift/api#1780
3febe3f
sohankunkerkar pushed a commit to sohankunkerkar/machine-config-operator that referenced this pull request Oct 9, 2024
@rvanderp3 @sohankunkerkar
drop feature gates dropped in openshift/api#1780
20793e3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@sdodson sdodson

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoelSpeed @openshift-ci-robot @openshift-bot @sdodson @openshift-merge-robot