Skip to content

MON-3971: Remove MetricsServer feature gate #1993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2024
Merged

MON-3971: Remove MetricsServer feature gate #1993

merged 1 commit into from
Oct 24, 2024

Conversation

@slashpai
Copy link
Member

@slashpai slashpai commented Aug 7, 2024

cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need
to be behind feature gate anymore.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Aug 7, 2024 •
edited by openshift-ci bot
Loading

@slashpai: This pull request references MON-3971 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

cluster-monitoring-operator now by default installs and configures metrics-server and it doesn't need
to be behind feature gate anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 7, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 7, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 7, 2024

Hello @slashpai! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 7, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2024
@slashpai
Copy link
Member Author

slashpai commented Aug 7, 2024

/retest

1 similar comment
@slashpai
Copy link
Member Author

slashpai commented Aug 8, 2024

/retest

@slashpai
Copy link
Member Author

slashpai commented Aug 8, 2024

/payload 4.17 nightly blocking

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

@slashpai: trigger 9 job(s) of type blocking for the nightly release of OCP 4.17

  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.17-upgrade-from-stable-4.16-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.17-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.17-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.17-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/35832820-554f-11ef-9dcc-9fa7f4650624-0

@slashpai slashpai changed the title WIP MON-3971: Remove MetricsServer feature gate MON-3971: Remove MetricsServer feature gate Aug 8, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2024
@machine424
Copy link

machine424 commented Aug 9, 2024

Thanks!

Maybe we should also clean it in payload-command/render/renderassets/rendered_manifests_test.go?

/hold
Let's wait for #1780 to set the pace as there are still discussions around "featuregates removing" #1780 (comment)

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2024
@machine424
Copy link

machine424 commented Aug 19, 2024

FYI #1780 was merged.
Reading the latest discussions, I think we should wait until version 4.19 to merge this one.

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Aug 20, 2024

Looking at the slack thread, I think we are ok to move forward, can you rebase please to address conflicts

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 2, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Sep 8, 2024

Feature was promoted to GA 4 months ago in 4.17

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 8, 2024
@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 8, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2024
@slashpai
Copy link
Member Author

slashpai commented Oct 22, 2024

@JoelSpeed could you please review again, rebased the branch

@slashpai
Copy link
Member Author

slashpai commented Oct 22, 2024

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 22, 2024
@slashpai
Copy link
Member Author

slashpai commented Oct 23, 2024

/retest-required

@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 24, 2024

/lgtm

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@slashpai
MON-3971: Remove MetricsServer feature gate
4f141fd 
cluster-monitoring-operator now by default installs
and configures metrics-server and it doesn't need
to be behind feature gate anymore.

Signed-off-by: Jayapriya Pai <janantha@redhat.com>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 24, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@JoelSpeed
Copy link
Contributor

JoelSpeed commented Oct 24, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 24, 2024
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, slashpai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 8a37acc and 2 for PR HEAD 4f141fd in total

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 24, 2024

/retest-required

Remaining retests: 0 against base HEAD 8a37acc and 2 for PR HEAD 4f141fd in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 24, 2024

@slashpai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 4f141fd link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 684b2b1 into openshift:master Oct 24, 2024
18 of 19 checks passed
@openshift-bot
Copy link

openshift-bot commented Oct 24, 2024

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202410241142.p0.g684b2b1.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@slashpai @openshift-ci-robot @machine424 @JoelSpeed @openshift-bot @openshift-merge-robot