-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-1449: add ObjectMeta to authorization and security types #2017
Conversation
so it is not picked up by applyconfiguration-gen
@atiratree: This pull request references WRKLDS-1449 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @atiratree! Some important instructions when contributing to openshift/api: |
@@ -232,7 +240,7 @@ type ResourceAccessReviewResponse struct { | |||
|
|||
// +genclient | |||
// +genclient:nonNamespaced | |||
// +genclient:skipVerbs=apply,get,list,create,update,patch,delete,deleteCollection,watch | |||
// +genclient:skipVerbs=apply,applyStatus,get,list,create,update,updateStatus,patch,delete,deleteCollection,watch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onlyVerb create?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it conflicts with
// +genclient:method=Create,verb=create,result=ResourceAccessReviewResponse
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generates create twice
// Create takes the representation of a resourceAccessReview and creates it. Returns the server's representation of the resourceAccessReview, and an error, if there is any.
func (c *resourceAccessReviews) Create(ctx context.Context, resourceAccessReview *v1.ResourceAccessReview, opts metav1.CreateOptions) (result *v1.ResourceAccessReview, err error) {
result = &v1.ResourceAccessReview{}
err = c.client.Post().
Resource("resourceaccessreviews").
VersionedParams(&opts, scheme.ParameterCodec).
Body(resourceAccessReview).
Do(ctx).
Into(result)
return
}
// Create takes the representation of a resourceAccessReview and creates it. Returns the server's representation of the resourceAccessReviewResponse, and an error, if there is any.
func (c *resourceAccessReviews) Create(ctx context.Context, resourceAccessReview *v1.ResourceAccessReview, opts metav1.CreateOptions) (result *v1.ResourceAccessReviewResponse, err error) {
result = &v1.ResourceAccessReviewResponse{}
err = c.client.Post().
Resource("resourceaccessreviews").
VersionedParams(&opts, scheme.ParameterCodec).
Body(resourceAccessReview).
Do(ctx).
Into(result)
return
}
good in concept. I suggest switch to the only support verbs. I'll approve for you to merge once the client bits are worked out /approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: atiratree, bertinatto, deads2k The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@atiratree: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
No description provided.