OCPBUGS-41111: vendor: Update openshift/api to pick up v4.17 and v4.18 capability sets #1875
Conversation
Catching up with [1]. Generated with:
$ go get github.com/openshift/api@master
$ go mod tidy
$ go mod vendor
$ git add -A go.* vendor
all using:
$ go version
go version go1.22.2 linux/amd64
This addresses [2]:
$ cat v4.17-basecap.yaml
---
apiVersion: v1
platform:
gcp:
foo: bar
capabilities:
baselineCapabilitySet: v4.17
$ ./oc adm release extract --install-config v4.17-basecap.yaml --included --credentials-requests --from quay.io/openshift-release-dev/ocp-release:4.17.0-rc.1-x86_64 --to /tmp/test
error: unrecognized baselineCapabilitySet "v4.17"
because pkg/cli/admin/release/extract_tools.go uses the vendored
openshift/api/config/v1 to unpack capabilities.
[1]: openshift/api#2022
[2]: https://issues.redhat.com/browse/OCPBUGS-41111
openshift-ci-robot
added
jira/severity-important
|
@wking: This pull request references Jira Issue OCPBUGS-41111, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
pre-merge verify pass /label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_oc/1875/pull-ci-openshift-oc-master-e2e-aws-ovn/1834034427999555584 failure is real and there is an issue after this openshift/api#2017. As far as I understand, this PR is opened due to more targeting to have another backport PR for 4.17?. I'm investigating the failure now as it will have an impact on rebasing of oc. |
|
Since rebasing process hasn't been completed yet, this version of openshift/api hasn't been vendored in other required pieces (especially openshift-apiserver openshift/openshift-apiserver#444). Failing test points out the implications caused by this PR because now oc has new openshift/api and all the commands such as create, run, etc. will send resources with this new But as far as I understand, the primary goal is to bump 4.17 and there shouldn't be any problem in there. I think, it is better to directly open a PR against release-4.17 and get valid-bug label from staff engineers. |
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Catching up with [1], and a backport-ish of 45ab914729 (vendor: Update openshift/api to pick up the v4.17 capability sets, 2024-09-11, openshift#1875), which may or may not land due to conflicts with the Kubernetes rebase [2]. Generated with: $ GOPROXY=direct go get github.com/openshift/api@release-4.17 $ go mod tidy $ go mod vendor $ git add -A go.* vendor all using: $ go version go version go1.22.2 linux/amd64 where GOPROXY=direct avoids a caching delay [3]: I committed a new change (or released a new version) to a repository, why isn't it showing up when I run go get -u or go list -m --versions? In order to improve our services' caching and serving latencies, new versions may not show up right away. If you want new code to be immediately available in the mirror, then first make sure there is a semantically versioned tag for this revision in the underlying source repository. Then explicitly request that version via go get module@version. The new version should be available within one minute. Note that if someone requested the version before the tag was pushed, it may take up to 30 minutes for the mirror's cache to expire and fresh data about the version to become available. If the version is still not available after 30 minutes, please file an issue. This addresses [4]: $ cat v4.17-basecap.yaml --- apiVersion: v1 platform: gcp: foo: bar capabilities: baselineCapabilitySet: v4.17 $ ./oc adm release extract --install-config v4.17-basecap.yaml --included --credentials-requests --from quay.io/openshift-release-dev/ocp-release:4.17.0-rc.1-x86_64 --to /tmp/test error: unrecognized baselineCapabilitySet "v4.17" because pkg/cli/admin/release/extract_tools.go uses the vendored openshift/api/config/v1 to unpack capabilities. [1]: openshift/api#2023 [2]: openshift#1875 (comment) [3]: https://proxy.golang.org/ [4]: https://issues.redhat.com/browse/OCPBUGS-41111
|
@wking: This pull request references Jira Issue OCPBUGS-41111. The bug has been updated to no longer refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Catching up with openshift/api#2022. Generated with:
all using:
This addresses OCPBUGS-41111:
because
pkg/cli/admin/release/extract_tools.gouses the vendoredopenshift/api/config/v1to unpack capabilities.