Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STOR-1599: Rebase to v2.0.5 for OCP 4.17 #76

Merged
merged 177 commits into from
Jul 16, 2024

Conversation

RomanBednar
Copy link

Diff to upstream v2.0.5:
kubernetes-sigs/aws-efs-csi-driver@v2.0.5...RomanBednar:rebase-v2.0.5

Notable changes:

Full changelog: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/CHANGELOG-2.x.md.md

@openshift/storage

wafuwafu13 and others added 30 commits July 26, 2023 18:11
Updating README for 'noresvport' mount option
…criticalAddonsOnly-default-toleration

Add CriticalAddonsOnly default toleration.
Bump Kubernetest libraroes at least to 1.26 to be able to bump
opentelemetry without any refactoring.
1.26.10 is the latest in 1.26 branch today.
Technically, only 0.44 is needed, but using the latest upstream release.
Fix typo in installation with public manifest
Fixed Posixuser nil pointer dereference issue
Update Static Provisioning README.md on mounttargetip option
The SC manifest contained a deprecated ApiVersion, updated the same.
Updated the apiversion in storageclass.yaml
arnavgup1 and others added 4 commits June 26, 2024 18:11
Additional changes:

- remove .github files
- do not overwrite GOARCH in makefile
- go mod tidy && go mod vendor
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 28, 2024

@RomanBednar: This pull request references STOR-1599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Diff to upstream v2.0.5:
kubernetes-sigs/aws-efs-csi-driver@v2.0.5...RomanBednar:rebase-v2.0.5

Notable changes:

Full changelog: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/CHANGELOG-2.x.md.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 28, 2024
Copy link

openshift-ci bot commented Jun 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2024
@RomanBednar
Copy link
Author

/label px-approved
/label docs-approved

@openshift-ci openshift-ci bot added px-approved Signifies that Product Support has signed off on this PR docs-approved Signifies that Docs has signed off on this PR labels Jul 1, 2024
Copy link

openshift-ci bot commented Jul 4, 2024

@RomanBednar: GitHub didn't allow me to assign the following users: approval, for, QE.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @duanwei33 for QE approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RomanBednar
Copy link
Author

/assign @duanwei33

Needs QE approval.

@Phaow
Copy link

Phaow commented Jul 11, 2024

/unassign @duanwei33

@Phaow
Copy link

Phaow commented Jul 11, 2024

/assign @Phaow

@Phaow
Copy link

Phaow commented Jul 15, 2024

Since the rebase efs-utils v2.0.0 replaces stunnel, which provides TLS encryptions for mounts, with efs-proxy, a component built in-house at AWS, I select the aws-ipi-proxy-sts configuration do the pre merge tests. I manually build the driver, operator, bundle images and install the pre merged build efs csi driver do a round regression tests all looks good.

$ oc rsh -c csi-driver aws-efs-csi-driver-controller-7b44d57474-mqwks
sh-5.1# /usr/bin/aws-efs-csi-driver --version
  1 kind: PersistentVolumeClaim
{
  "driverVersion": "v2.0.5",
  "gitCommit": "d4f52ca9108b6e669d9fae3bbf5606f56a9ba805",
  "buildDate": "2024-07-15T04:43:14Z",
  "efsClientSource": "k8s",
  "goVersion": "go1.21.9 (Red Hat 1.21.9-1.el9_4) X:strictfipsruntime",
  "compiler": "gc",
  "platform": "linux/amd64"
}

sh-5.1# env | grep -i 'http'
KUBERNETES_SERVICE_PORT_HTTPS=443
SOURCE_GIT_URL=https://github.com/openshift/images
HTTPS_PROXY=http://XXXXXX.us-east-2.compute.amazonaws.com
HTTP_PROXY=http://XXXXXX.us-east-2.compute.amazonaws.com


# Regression test result
52 pass, 18 skip (55m22s)

@Phaow
Copy link

Phaow commented Jul 15, 2024

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Jul 15, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 15, 2024

@RomanBednar: This pull request references STOR-1599 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

Diff to upstream v2.0.5:
kubernetes-sigs/aws-efs-csi-driver@v2.0.5...RomanBednar:rebase-v2.0.5

Notable changes:

Full changelog: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/CHANGELOG-2.x.md.md

@openshift/storage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jsafrane
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 16, 2024
Copy link

openshift-ci bot commented Jul 16, 2024

@RomanBednar: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit fba2243 into openshift:master Jul 16, 2024
7 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-aws-efs-csi-driver-container-v4.17.0-202407161541.p0.gfba2243.assembly.stream.el9 for distgit ose-aws-efs-csi-driver.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.