Move all functionality for assume command into credentials/console

[AlexVulaj]

What type of PR is this?

cleanup/feature

What this PR does / Why we need it?

takes the logic from the new assume/token commands (which are not yet in use anywhere) and consolidates them into the existing commands. this will prevent SREs from having to change anything about their existing workflows.

Which Jira/Github issue(s) does this PR fix?

OSD-19436

Pre-checks (if applicable)

• Ran unit tests locally
• Validated the changes in a cluster
• Included documentation changes with PR

Steps to test locally

As a pre-requisite, run either backplane cloud console or backplane cloud credentials against an existing, non-ROSA cluster and make sure it still works as it always has. For the new flow:

1. Create a new ROSA STS cluster in stage. The "new flow" should be enabled in the Red Hat org in stage.
2. Once the cluster is created and has been set up with all support roles, use "backplane cloud console" or "backplane cloud credentials" against that cluster.
   Note - at this point, it is not uncommon to see a message on the screen saying "Waiting for IAM policy changes to resolve..."
3. Verify that legitimate credentials or a console url are printed out.

[AlexVulaj]

/hold

I'm putting this up now for review, but we must hold off on merging until this conversation is resolved. In short - the OCM endpoint that determines a cluster's support jump role needs an update to how it makes it determination.

[mrWinston]

Nice! I really like that this doesn't only make it easier for SREs but also makes the code easier to understand and reason about! I have yet to test the changes locally, which is why i didn't approve the PR right now. The comments I left don't neccessarily need to be addressed as they're all pretty minor.

[mrWinston]

Really Minor Nitpick: Maybe use \t to indent the lines in the String. Just from looking at it in the code it's a bit confusing right now as it's the same indentation level as the surrounding code.

[AlexVulaj]

This was all copy-paste from what used to be in the old console and credentials commands, so I wanted to keep that identical.

I also don't believe these should be indented. Right now this will all print to a terminal as such:

Temporary Credentials:
AccessKeyID: test-key
SecretAccessKey: test-secret
SessionToken: test-token
Region: test-region
Expires: test-expiration

I believe that's what we'd want.

[feichashao]

It seems we don't have a good way to make indentation look nice in raw string. golang/go#32590

Let's keep it as is, as long as the output is what we want.

[iamkirkbater]

Non-blocking - I wonder if we could use go's text/templates here to better define these strings separately. I think "fixing" this should be a separate effort, though.

[mrWinston]

Question: do you think it made sense to add some tests to this again?

[AlexVulaj]

For functions like this, it feels weird to test because my tests would essentially just do exactly what the function is already doing. For example...

	type fields struct {
		AccessKeyID     string
		SecretAccessKey string
		SessionToken    string
		Region          string
		Expiration      string
	}
	tests := []struct {
		name   string
		fields fields
		want   string
	}{
		{
			name:   "Contains no values",
			fields: fields{},
			want:   fmt.Sprintf(AwsExportFormat, "", "", "", ""), <-- this is just what the function itself is doing
		},
	}

That said - I could still go either way. Any thoughts?

[AlexVulaj]

/unhold

[codecov-commenter]

We're currently processing your upload. This comment will be updated when the results are available.

[feichashao]

Hi @AlexVulaj , thanks for the PR to consolidate commands! I am new to the "new flow", and I wonder if there's any steps that I can try that locally?

[AlexVulaj]

Hey @feichashao , more details on the new flow can be found in the ADR, and this design doc.

For steps to test locally, I'll add those to the description of this PR directly.

[openshift-ci]

@AlexVulaj: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[samanthajayasinghe]

/lgtm

[wanghaoran1988]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AlexVulaj, samanthajayasinghe, wanghaoran1988

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [wanghaoran1988]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mjlshen]

This previously exported function should not have been removed, osdctl depends on it https://github.com/openshift/osdctl/blob/04c8575e83b30d0199ff0d1cfd5b81761f870556/pkg/osdCloud/aws.go#L189