OSD-19729: Enables ocm backplane login to set default namespace or one provided as an argument #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Requirements are changing. Hence, I have put this PR back into draft state. |
|
/retest-required |
2 similar comments
|
/retest-required |
|
/retest-required |
amej
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@amej: This pull request references OSD-19729 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
/retest-required |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
+ Coverage 48.27% 48.35% +0.07%
==========================================
Files 55 55
Lines 4182 4188 +6
==========================================
+ Hits 2019 2025 +6
Misses 1844 1844
Partials 319 319
|
devppratik
suggested changes
Mar 7, 2024
amej
added a commit
to amej/backplane-cli
that referenced
this pull request
Mar 7, 2024
…ft#315 (comment) Signed-off-by: Ameya Sathe <asathe@redhat.com>
|
@amej: This pull request references OSD-19729 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
cmd/ocm-backplane/login/login.go
Outdated
| &args.defaultNamespace, | ||
| "namespace", | ||
| "n", | ||
| "openshift-backplane-srep", |
There was a problem hiding this comment.
I don't think it's good to set the default NS as open shift-backplane-step always because the default NS changes based on the user role.
- id: "SREP"
saNamespace: "openshift-backplane-srep"
- id: "CEE"
saNamespace: "openshift-backplane-cee"If CEE login to the cluster openshift-backplane-srep NS may not exist
There was a problem hiding this comment.
I don't think it's good to set the default NS as
open shift-backplane-stepalways because the default NS changes based on the user role.
I agree with your thought.
- id: "SREP" saNamespace: "openshift-backplane-srep" - id: "CEE" saNamespace: "openshift-backplane-cee"
I did not spot this mapping inside the backplane-cli repo .
How can my program fetch this mapping dynamically and set the default namespace accordingly ?
How can we make the program future-ready for scenarios like addition of new user roles mapped to different namespace or, organizations preventing these user roles from setting their context to these default namespace at the time of login ?
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: amej The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@amej: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
3 tasks
|
Force-sync of the repo caused this issue to be marked closed. |
amej
pushed a commit
to amej/backplane-cli
that referenced
this pull request
Apr 11, 2024
Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.401 to 0.1.402. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](https://github.com/openshift-online/ocm-sdk-go/commits) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> OSD-21060: backplane cloud console open in proper region (openshift#343) * backplane cloud console open in proper region * replace missing ocm-sdk-go v0.1.402 by ocm-sdk-go v0.1.403 Development complete. Local testing complete. add more approvers and reviewers OSD-16899: Backplane CLI debug output lets you know the ELB its connecting to. (openshift#331) * feat(OSD-16899): Backplane CLI debug output should let you know which backplane server it is connecting through at the time of login Signed-off-by: Ameya Sathe <asathe@redhat.com> * feat(OSD-16899): Prints descriptive string Signed-off-by: Ameya Sathe <asathe@redhat.com> * feat(OSD-16899): Adds the doc link containing mapping of the ELB to the backplane api servers Signed-off-by: Ameya Sathe <asathe@redhat.com> * style(OSD-16899) Signed-off-by: Ameya Sathe <asathe@redhat.com> * style(OSD-16899): Function names should ideally be written in CamelCase. Signed-off-by: Ameya Sathe <asathe@redhat.com> * test(OSD-16899): Logs the error string instead of returing the error as error type externally Signed-off-by: Ameya Sathe <asathe@redhat.com> * style(OSD-16899): Renames variable to camelcase -Prints warning because the script does not get terminated Signed-off-by: Ameya Sathe <asathe@redhat.com> * code(OSD-16899): Finally, the convention in Go is to use MixedCaps or mixedCaps rather than underscores to write multiword Signed-off-by: Ameya Sathe <asathe@redhat.com> * code(OSD-16899): Go convention to use mixedCase variables for non-exported vars Signed-off-by: Ameya Sathe <asathe@redhat.com> * fix(OSD-16899): Switches to generic message devoid of Red Hat Internal links Signed-off-by: Ameya Sathe <asathe@redhat.com> * Update cmd/ocm-backplane/login/login.go making it more generic Co-authored-by: Supreeth Basabattini <sbasabat@redhat.com> --------- Signed-off-by: Ameya Sathe <asathe@redhat.com> Co-authored-by: Supreeth Basabattini <sbasabat@redhat.com> Do not override KUBECONFIG when RunElevate Bump ubi8/ubi from 8.9-1107.1706791207 to 8.9-1136 Bumps ubi8/ubi from 8.9-1107.1706791207 to 8.9-1136. --- updated-dependencies: - dependency-name: ubi8/ubi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/aws/aws-sdk-go-v2/config from 1.27.0 to 1.27.4 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.0 to 1.27.4. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.0...config/v1.27.4) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Modify the awk command to exclude the rhel-specific binary initial commit OSD-20994 adding --manager flag, logs changes suggested in review Fix monitoring-plugin on podman Bump github.com/openshift-online/ocm-sdk-go from 0.1.403 to 0.1.405 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.403 to 0.1.405. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.403...v0.1.405) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> use tmpdir for testjob to import lib Add iniitla debug messages to login.go First version of loggos change fmt.println to logger.debugln Change varible names Added additional ocm-backplane login debug logging Added Tests for cmd/ocm-backplane/console/ Added tests for validatecontainer engine, getcontainerengineimpl and the run function. Added isTest flag to console options to prevent the occurance of an infinite loop Added tests for cleanup function for console options Added an additional test for ports "Remove test for cleanup function" Uncapitalize strings Expect error from run command to be lower case Split up the Validate Container Engine Tests Added podman and docker into a temp path Added exec permissions to temp file Change order of errors Implemented isTest flag in consoleOptions, this is a workaround since that environment varibles within contains cannot be changed, this purely Incorperated validateContainerEngine into consoleOptions, this is due to some problems with containers and testing Make changes in test for validateContainerEngine Added missing method Make lint changes to o.test flag Roll back changes to validateContainerEngine Added a functionality to mock the existence of a podman and docker binary, but they are actually just empty executable files in tmpfs Made changes to the circuit breaker at run Cleaned up some formatting issues Added tests for ocm-backplane and made some formatting and syntax changes Alternative workaround for console test of the run function in console.go via mock interfaces Moved temp path configuration utilities in console_test to console_test_utils added file console_tests_util.go Added defensive code into cleanup and moved mockinterface into utils Commenting Removed uncessary comments Bump github.com/openshift-online/ocm-sdk-go from 0.1.405 to 0.1.409 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.405 to 0.1.409. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.405...v0.1.409) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/aws/aws-sdk-go-v2/credentials from 1.17.4 to 1.17.7 Bumps [github.com/aws/aws-sdk-go-v2/credentials](https://github.com/aws/aws-sdk-go-v2) from 1.17.4 to 1.17.7. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Changelog](https://github.com/aws/aws-sdk-go-v2/blob/v1.17.7/CHANGELOG.md) - [Commits](aws/aws-sdk-go-v2@v1.17.4...v1.17.7) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/credentials dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/aws/aws-sdk-go-v2/config from 1.27.4 to 1.27.7 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.4 to 1.27.7. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.4...config/v1.27.7) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> feat: Enable backplane login through PD incident link or ID Bump github.com/openshift-online/ocm-sdk-go from 0.1.409 to 0.1.411 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.409 to 0.1.411. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.409...v0.1.411) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump golang.org/x/term from 0.17.0 to 0.18.0 Bumps [golang.org/x/term](https://github.com/golang/term) from 0.17.0 to 0.18.0. - [Commits](golang/term@v0.17.0...v0.18.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> fix: Include condition to check if arg pd is empty OSD-21670: Reduce verbosity level of pd-token config feat(OSD-19729): Enables ocm backplane login to set default namespace post-login Signed-off-by: Ameya Sathe <asathe@redhat.com> refactor(OSD-19729): Removes unintended line -Sorts the struct Signed-off-by: Ameya Sathe <asathe@redhat.com> docs(OSD-19729): For setting namespace as part of default context Signed-off-by: Ameya Sathe <asathe@redhat.com> refactor(OSD-19729): Removes whitespace Signed-off-by: Ameya Sathe <asathe@redhat.com> test(OSD-19729): Changes the assumed namespace Signed-off-by: Ameya Sathe <asathe@redhat.com> test(OSD-19729): Replaces instances of default with the openshift-backplane-sre namespace Signed-off-by: Ameya Sathe <asathe@redhat.com> test(OSD-19729): Hardcodes value of namespace ( defaultNamespace ) into test files Signed-off-by: Ameya Sathe <asathe@redhat.com> Attempt to write a test case Signed-off-by: Ameya Sathe <asathe@redhat.com> test(OSD-19729): Fixes the test erorr reported for the test 'Login when cluster ID is not provided' - string: default does not match the expected "string: openshift-backplane-srep" Signed-off-by: Ameya Sathe <asathe@redhat.com> style(OSD-19729): Accepts devppratik's suggestion provided at openshift#315 (comment) Signed-off-by: Ameya Sathe <asathe@redhat.com> OSD-19729: Malformed expression Signed-off-by: Ameya Sathe <asathe@redhat.com> feat(OSD-19729): Default behaviour is to not set a namespace at all Signed-off-by: Ameya Sathe <asathe@redhat.com> Bump github.com/aws/aws-sdk-go-v2/config from 1.27.7 to 1.27.9 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.7 to 1.27.9. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.7...config/v1.27.9) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/openshift-online/ocm-sdk-go from 0.1.411 to 0.1.413 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.411 to 0.1.413. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.411...v0.1.413) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/onsi/gomega from 1.31.1 to 1.32.0 Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.31.1 to 1.32.0. - [Release notes](https://github.com/onsi/gomega/releases) - [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md) - [Commits](onsi/gomega@v1.31.1...v1.32.0) --- updated-dependencies: - dependency-name: github.com/onsi/gomega dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> make the testjob source dir configurable refactor(OSD-19729): Assumes 'default' namespace as fallback mechanism in case string is not passed as an argument Signed-off-by: Ameya Sathe <asathe@redhat.com> Bump github.com/aws/aws-sdk-go-v2/config from 1.27.9 to 1.27.10 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.9 to 1.27.10. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.9...config/v1.27.10) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump sigs.k8s.io/kustomize/api from 0.15.0 to 0.16.0 Bumps [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) from 0.15.0 to 0.16.0. - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@api/v0.15.0...api/v0.16.0) --- updated-dependencies: - dependency-name: sigs.k8s.io/kustomize/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Use md5 hash for session name when assuming Org Role in new backplane flow Update dockerfile to exclude all arch binaries test(OSD-19729): Validates the argument satisfies Kubernetes namespace rules Signed-off-by: Ameya Sathe <asathe@redhat.com> Bump github.com/aws/aws-sdk-go-v2/config from 1.27.10 to 1.27.11 Bumps [github.com/aws/aws-sdk-go-v2/config](https://github.com/aws/aws-sdk-go-v2) from 1.27.10 to 1.27.11. - [Release notes](https://github.com/aws/aws-sdk-go-v2/releases) - [Commits](aws/aws-sdk-go-v2@config/v1.27.10...config/v1.27.11) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go-v2/config dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Bump ubi8/ubi from 8.9-1136 to 8.9-1160 Bumps ubi8/ubi from 8.9-1136 to 8.9-1160. --- updated-dependencies: - dependency-name: ubi8/ubi dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Bump github.com/openshift-online/ocm-sdk-go from 0.1.413 to 0.1.414 Bumps [github.com/openshift-online/ocm-sdk-go](https://github.com/openshift-online/ocm-sdk-go) from 0.1.413 to 0.1.414. - [Release notes](https://github.com/openshift-online/ocm-sdk-go/releases) - [Changelog](https://github.com/openshift-online/ocm-sdk-go/blob/main/CHANGES.md) - [Commits](openshift-online/ocm-sdk-go@v0.1.413...v0.1.414) --- updated-dependencies: - dependency-name: github.com/openshift-online/ocm-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> OSD-21419: Fixed console container cleanup issues refactor(OSD-19729): fewer variable assignments Accepted suggestion of supreeth. Co-authored-by: Supreeth Basabattini <sbasabat@redhat.com> refactor(OSD-19729): Making it more generic because backplane is used by different personas, including SRE, TAMs etc. Co-authored-by: Supreeth Basabattini <sbasabat@redhat.com> refactor(OSD-19729): only be logged if args.defaultNamespace!="default" Signed-off-by: Ameya Sathe <asathe@redhat.com> Bump sigs.k8s.io/kustomize/api from 0.16.0 to 0.17.1 Bumps [sigs.k8s.io/kustomize/api](https://github.com/kubernetes-sigs/kustomize) from 0.16.0 to 0.17.1. - [Release notes](https://github.com/kubernetes-sigs/kustomize/releases) - [Commits](kubernetes-sigs/kustomize@api/v0.16.0...api/v0.17.1) --- updated-dependencies: - dependency-name: sigs.k8s.io/kustomize/api dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Bump golang.org/x/term from 0.18.0 to 0.19.0 Bumps [golang.org/x/term](https://github.com/golang/term) from 0.18.0 to 0.19.0. - [Commits](golang/term@v0.18.0...v0.19.0) --- updated-dependencies: - dependency-name: golang.org/x/term dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… post-login
What type of PR is this?
feature
What this PR does / Why we need it?
As a SRE, I want
backplane loginto set a default namespace for me to run commands likeoc debug node/xxx, the namespace should be openshift-backplane-srep or other appropriate namespace passed as argument to the ocm backplane loginWhich Jira/Github issue(s) does this PR fix?
Resolves #OSD-19729
Special notes for your reviewer
Once merged,
./ocm-backplane login --helpwill displayExample:
Considering cluster ID is 28lje9u3jd59j3dmf36sojgpa32qrag3 .
Output will be
Output will be
_Using project "openshift-sre-pruning" on server "https://api.stage.backplane.openshift.com/backplane/cluster/28lje9u3jd59j3dmf36sojgpa32qrag3/"._Pre-checks (if applicable)