OSD-19729: Enables ocm backplane login to provide default namespace as an argument #374

amej · 2024-03-21T17:39:57Z

What type of PR is this?

feature
documentation
unit-test

What this PR does / Why we need it?

As a SRE, I want backplane login to prompt for a default namespace for me to run commands like oc debug node/xxx.

Which Jira/Github issue(s) does this PR fix?

Resolves #OSD-19729

Special notes for your reviewer

Once merged, ./ocm-backplane login --help will display

Running login command will send a request to backplane api
...
Usage:
  ocm-backplane login <CLUSTERID|EXTERNAL_ID|CLUSTER_NAME|CLUSTER_NAME_SEARCH> [flags]
...
Flags:
     -n,  --namespace string   Sets a default namespace for SRE to run commands like oc debug node/xxx
...  
Example: 
Considering cluster name as asathe-19729     

- Without options

./ocm-backplane login asathe-19729
oc project

Output will be

> _Using project "default" on server "https://api.stage.backplane.openshift.com/backplane/cluster/2afh53rispkj3vbsp6asa4f7hlpb78uv/"._

- By passing a valid kubernetes namespace to the option ' **_namespace_** '

./ocm-backplane login --namespace openshift-sre-pruning 28lje9u3jd59j3dmf36sojgpa32qrag3
oc project

Output will be
`_Using project "openshift-backplane-srep" on server "https://api.stage.backplane.openshift.com/backplane/cluster/2afh53rispkj3vbsp6asa4f7hlpb78uv/"._`

- By passing an **invalid  namespace** to the option ' **_namespace_** '

./ocm-backplane login --namespace "" asathe-19729


Following error  displayed.
_ERRO[0016]  is not a valid namespace_

./ocm-backplane login --namespace 'kube_system' asathe-19729

Following error  displayed.                                                                                                                                
ERRO[0012] kube_system is not a valid namespace

Hence, the command "oc status" will display the following error
error: Missing or incomplete configuration info. Please point to an existing, complete config file:

Please do refer to the prior discussion in the #315 .

Pre-checks (if applicable)

Ran unit tests locally
Validated the changes in a cluster
Included documentation changes with PR

openshift-ci-robot · 2024-03-21T17:40:00Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2024-03-21T17:40:01Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

openshift-ci-robot · 2024-03-22T09:08:38Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

codecov-commenter · 2024-03-28T12:03:13Z

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #374      +/-   ##
==========================================
+ Coverage   44.50%   44.61%   +0.11%     
==========================================
  Files          62       62              
  Lines        5159     5173      +14     
==========================================
+ Hits         2296     2308      +12     
- Misses       2547     2548       +1     
- Partials      316      317       +1

Files	Coverage Δ
cmd/ocm-backplane/login/login.go	`74.55% <86.66%> (+0.58%)`	⬆️

openshift-ci-robot · 2024-03-29T11:43:09Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-03-29T11:43:55Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

amej · 2024-04-01T05:49:36Z

@Tafhim , @supreeth7 and @devppratik : Please can you review ?

cmd/ocm-backplane/login/login.go

samanthajayasinghe · 2024-04-04T20:30:27Z

@amej Can you pls squash the commits ?

devppratik · 2024-04-05T06:01:24Z

/label tide/merge-method-squash

amej · 2024-04-05T08:03:17Z

@devppratik : Does this label free me up from the work of squashing commits locally on my laptop & force pushing them to the fork's feature branch?

openshift-ci-robot · 2024-04-06T16:09:16Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-04-06T16:17:29Z

@amej: This pull request references OSD-19729 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

amej

I have reviewed the comments. 0560e97 contains the recommendations.

samanthajayasinghe · 2024-04-08T21:12:11Z

@amej let me know if you need any help to squash the commit manually

cmd/ocm-backplane/login/login.go

amej · 2024-04-11T08:09:09Z

@supreeth7 :
As my PR was showing 34 commits, on my current branch OSD-19729; I performed ' git rebase HEAD~34.
It showed me 54 items. I 'pick' first row & rest was 'squash' . I had to fix multiple merge commits during the rebase.
After rebasing my local branch OSD-19729 on top of the github based OSD-19729, I could push the changes.
Here is the current status with 35 commits : https://github.com/openshift/backplane-cli/pull/374/commits .

amej

@supreeth7 : Changes reviewed and action taken including squashing commits locally & pushing them.

supreeth7 · 2024-04-12T04:20:26Z

@amej thanks for addressing the review comments.

The commit number is too wide for it to be merged, even with the tide plugin squashing it, can you try squashing your commits without any trailing commit history?

…f login Signed-off-by: Ameya Sathe <asathe@redhat.com>

amej · 2024-04-12T07:35:40Z

@supreeth7 : Please find a single commit now. I force pushed the changes to the OSD-19729 branch.

amej · 2024-04-12T07:37:59Z

@devppratik guided me to opt for the easy solution .
I opted to force push my changes to the OSD-19729 branch.
Now you will find a single commit .
Thank you for your patience.

openshift-ci · 2024-04-12T07:40:18Z

@amej: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

supreeth7

/lgtm

openshift-ci · 2024-04-12T07:48:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: amej, supreeth7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [supreeth7]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 21, 2024

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 21, 2024

amej marked this pull request as ready for review March 22, 2024 09:09

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 22, 2024

openshift-ci bot requested review from bmeng and typeid March 22, 2024 09:09

amej mentioned this pull request Mar 22, 2024

OSD-19729: Enables ocm backplane login to set default namespace or one provided as an argument #315

Closed

3 tasks

samanthajayasinghe reviewed Apr 4, 2024

View reviewed changes

cmd/ocm-backplane/login/login.go Outdated Show resolved Hide resolved

openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 5, 2024

amej commented Apr 6, 2024

View reviewed changes

amej requested a review from samanthajayasinghe April 6, 2024 16:21

supreeth7 suggested changes Apr 9, 2024

View reviewed changes

cmd/ocm-backplane/login/login.go Outdated Show resolved Hide resolved

cmd/ocm-backplane/login/login.go Outdated Show resolved Hide resolved

cmd/ocm-backplane/login/login.go Outdated Show resolved Hide resolved

amej requested a review from supreeth7 April 11, 2024 07:17

amej commented Apr 11, 2024

View reviewed changes

feat(OSD-19729): Enables to pass a namespace as an argument at time o…

62dc18b

…f login Signed-off-by: Ameya Sathe <asathe@redhat.com>

amej force-pushed the OSD-19729 branch from 182e731 to 62dc18b Compare April 12, 2024 07:24

supreeth7 approved these changes Apr 12, 2024

View reviewed changes

openshift-ci bot assigned supreeth7 Apr 12, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 12, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2024

openshift-merge-bot bot merged commit 2154c96 into openshift:main Apr 12, 2024
7 checks passed

OSD-19729: Enables ocm backplane login to provide default namespace as an argument #374

OSD-19729: Enables ocm backplane login to provide default namespace as an argument #374

Conversation

amej commented Mar 21, 2024 • edited Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

openshift-ci-robot commented Mar 21, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

openshift-ci bot commented Mar 21, 2024

openshift-ci-robot commented Mar 22, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

codecov-commenter commented Mar 28, 2024 • edited Loading

Codecov Report

openshift-ci-robot commented Mar 29, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

openshift-ci-robot commented Mar 29, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

amej commented Apr 1, 2024

samanthajayasinghe commented Apr 4, 2024

devppratik commented Apr 5, 2024

amej commented Apr 5, 2024

openshift-ci-robot commented Apr 6, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

openshift-ci-robot commented Apr 6, 2024 • edited by openshift-ci bot Loading

What type of PR is this?

What this PR does / Why we need it?

Which Jira/Github issue(s) does this PR fix?

Special notes for your reviewer

Pre-checks (if applicable)

amej left a comment

Choose a reason for hiding this comment

samanthajayasinghe commented Apr 8, 2024

amej commented Apr 11, 2024 • edited Loading

amej left a comment

Choose a reason for hiding this comment

supreeth7 commented Apr 12, 2024

amej commented Apr 12, 2024 • edited by openshift-ci bot Loading

amej commented Apr 12, 2024 • edited by openshift-ci bot Loading

openshift-ci bot commented Apr 12, 2024

supreeth7 left a comment

Choose a reason for hiding this comment

openshift-ci bot commented Apr 12, 2024

amej commented Mar 21, 2024 •

edited

Loading

openshift-ci-robot commented Mar 21, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 22, 2024 •

edited by openshift-ci bot

Loading

codecov-commenter commented Mar 28, 2024 •

edited

Loading

openshift-ci-robot commented Mar 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Mar 29, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 6, 2024 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Apr 6, 2024 •

edited by openshift-ci bot

Loading

amej commented Apr 11, 2024 •

edited

Loading

amej commented Apr 12, 2024 •

edited by openshift-ci bot

Loading

amej commented Apr 12, 2024 •

edited by openshift-ci bot

Loading