Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login through PagerDuty incident link or ID #368

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

Tessg22
Copy link
Contributor

@Tessg22 Tessg22 commented Mar 12, 2024

What type of PR is this?

feature

What this PR does / Why we need it?

--

Which Jira/Github issue(s) does this PR fix?

Resolves OSD-19682

Special notes for your reviewer

I'm currently out of ideas how to test the scenario described in the test case "should fail to extract cluster ID when the 'details' field under Common Event Format Details is missing or invalid" due to the sensitivity of the token information involved. Considering this limitation, I'm leaning towards removing this test case from the suite. Unless someone has an idea which would be secure.

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@Tessg22
Copy link
Contributor Author

Tessg22 commented Mar 12, 2024

Fyi, code review has been completed in original PR #337

@codecov-commenter
Copy link

codecov-commenter commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 35.71429% with 63 lines in your changes are missing coverage. Please review.

Project coverage is 47.98%. Comparing base (6bc8b44) to head (7d7a70b).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #368      +/-   ##
==========================================
- Coverage   48.27%   47.98%   -0.30%     
==========================================
  Files          55       56       +1     
  Lines        4182     4272      +90     
==========================================
+ Hits         2019     2050      +31     
- Misses       1844     1900      +56     
- Partials      319      322       +3     
Files Coverage Δ
cmd/ocm-backplane/config/config.go 100.00% <100.00%> (ø)
pkg/cli/config/config.go 75.23% <100.00%> (+3.23%) ⬆️
cmd/ocm-backplane/config/get.go 27.27% <0.00%> (-2.73%) ⬇️
cmd/ocm-backplane/config/set.go 14.28% <0.00%> (-1.51%) ⬇️
cmd/ocm-backplane/login/login.go 73.97% <62.50%> (-2.06%) ⬇️
pkg/pagerduty/pagerduty.go 16.66% <16.66%> (ø)

README.md Outdated Show resolved Hide resolved
@samanthajayasinghe
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: samanthajayasinghe, Tessg22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
Copy link
Contributor

openshift-ci bot commented Mar 13, 2024

@Tessg22: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit b021469 into openshift:main Mar 13, 2024
7 checks passed
@Tessg22 Tessg22 deleted the backplane-login-pd branch March 13, 2024 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants