Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include condition to check if arg pd is empty #372

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Tessg22
Copy link
Contributor

@Tessg22 Tessg22 commented Mar 19, 2024

What type of PR is this?

bug fix

What this PR does / Why we need it?

ERRO[0003] invalid configuration: no configuration has been provided, try setting KUBERNETES_MASTER environment variable

Fixes login via PagerDuty incident link or ID.

Which Jira/Github issue(s) does this PR fix?

#368

@openshift-ci openshift-ci bot requested review from Dee-6777 and Tafhim March 19, 2024 10:09
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

@Tessg22: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Dee-6777
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 19, 2024
Copy link
Contributor

openshift-ci bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dee-6777, Tessg22

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4b19b8e into openshift:main Mar 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants