Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log when we discard proxies and default to the first proxy if all fail healthchecks #428

Merged
merged 1 commit into from
May 21, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented May 21, 2024

What type of PR is this?

bug

What this PR does / Why we need it?

The message

WARN[0002] No proxy configuration available. This may result in failing commands as backplane-api is only available from select networks.

is misleading when a proxies are specified, but they are failing health checks. This PR adds logging when proxies are discarded and falls back to selecting the first specified proxy if all fail health checks.

Which Jira/Github issue(s) does this PR fix?

OSD-23471

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
…l healthchecks

Signed-off-by: Michael Shen <mshen@redhat.com>
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.49%. Comparing base (59d5cbc) to head (987d8a0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #428      +/-   ##
==========================================
+ Coverage   44.24%   44.49%   +0.25%     
==========================================
  Files          63       63              
  Lines        5282     5286       +4     
==========================================
+ Hits         2337     2352      +15     
+ Misses       2624     2617       -7     
+ Partials      321      317       -4     
Files Coverage Δ
pkg/cli/config/config.go 80.73% <83.33%> (+5.49%) ⬆️

... and 1 file with indirect coverage changes

@samanthajayasinghe
Copy link
Contributor

/lgtm

Copy link
Contributor

openshift-ci bot commented May 21, 2024

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link
Contributor

openshift-ci bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mjlshen, samanthajayasinghe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [mjlshen,samanthajayasinghe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ca7d234 into openshift:main May 21, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants