Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect variable name and log message #429

Merged
merged 1 commit into from
May 22, 2024

Conversation

mjlshen
Copy link
Contributor

@mjlshen mjlshen commented May 22, 2024

What type of PR is this?

cleanup

What this PR does / Why we need it?

In #428 I mistakenly changed the variable name to proxyHealthCheckURL, but it was correct before. config.URL holds the backplane URL, not the proxy URL.

Which Jira/Github issue(s) does this PR fix?

OSD-23471

Special notes for your reviewer

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR

Signed-off-by: Michael Shen <mshen@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2024
Copy link
Contributor

openshift-ci bot commented May 22, 2024

@mjlshen: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.49%. Comparing base (ca7d234) to head (7a2015b).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #429   +/-   ##
=======================================
  Coverage   44.49%   44.49%           
=======================================
  Files          63       63           
  Lines        5286     5286           
=======================================
  Hits         2352     2352           
  Misses       2617     2617           
  Partials      317      317           
Files Coverage Δ
pkg/cli/config/config.go 80.73% <66.66%> (ø)

@bmeng
Copy link
Contributor

bmeng commented May 22, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2024
Copy link
Contributor

openshift-ci bot commented May 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bmeng, mjlshen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 7a1ddc7 into openshift:main May 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants