-
Notifications
You must be signed in to change notification settings - Fork 21
Add a tool to cross-validate CI config and OCP config #121
base: master
Are you sure you want to change the base?
Add a tool to cross-validate CI config and OCP config #121
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d6e3332
to
b540256
Compare
@smarterclayton seems to have no error output if we allow for |
43c0b7c
to
c42c1ed
Compare
Just kidding..
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code LGTM, leaving the proper review for the real stakeholders
If it is intended for a human to read, could it be more like, say, yaml? The output is pretty hard to make sense of. We should probably be looking at 4.1 as I think we're done building 4.0.
This is one of about 10 builds where there is no external source. It is simply built out of dist-git sources that are maintained by the owners. I have no idea what OKD does for the equivalent but my guess is you should ignore these.
Same image, same issue. What kind of repo is this? We have source github repos, and a set of yum repos that are enabled for the build. Messaging would be clearer if it indicated it's a source code repo...
It's a bit silly that this has .git on the end. I can change it. But can't the validator compare normalized versions? .git doesn't actually matter.
Not certain what this is saying - is ERRO[0000] No configuration for the expected product image found in OCP build data. branch=master image=baremetal-machine-controllers ocp-build-data-value=openshift/ose-baremetal-machine-controllers org=openshift repo=cluster-api-provider-baremetal source-file=openshift-cluster-api-provider-baremetal-master.yaml Renamed baremetal-machine-controllers this morning; see if this went away.
A branch is set, it's just Could you think about how you want to address these and regenerate for 4.1? |
4.1 does not exist in CI ... @smarterclayton should it? I can generate those today if so
Isn't this the point of this exercise? I don't see a good reason to let them have their own dist-git
Didn't realize you could have the
Sorry, I understood our conversation over BJNS to mean you wanted me to validate the fallback. I can change to validating the target. |
@sosiouxme updated
|
c42c1ed
to
63b838b
Compare
|
Current errors:
|
599776f
to
1e99233
Compare
https://jira.coreos.com/browse/ART-550 for bringing configs into alignment (mostly, no more distgit-only OCP builds). |
hi, @stevekuznetsov , could you please push your change I think the latest log is not 100% same as your code. |
Yep, give me a day or two. |
We've bumped development branches to 4.1 so I can start validating this |
1e99233
to
386b19e
Compare
386b19e
to
3028753
Compare
@shiywang updated, now I see:
|
3028753
to
6d171fd
Compare
@sosiouxme ok, read in the alias from the group yaml and did hackery to allow origin CI to match with OSE build data
|
Upstream and Downstream just have different names a lot of the time and don't always follow the usual process.... for one, remember that the ocp-build-data names are dist-git names not the released image name. There's zero we can do to change this as we require the distgit name for building.
Those are just a few I pulled out. But you get the point. |
6d171fd
to
552dc5c
Compare
552dc5c
to
8c8a0cb
Compare
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
8c8a0cb
to
64ae61c
Compare
@smarterclayton @adammhaile @tbielawa @sosiouxme with the blacklist...
|
@stevekuznetsov: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
For those kind of messages or similar ( release-4.1 vs master )... not very useful, we should filter out since
|
I mean what you are literally reading in the error message is that the ocp-build-data configuration did use master... |
just talked with @sosiouxme 1 and |
Signed-off-by: Steve Kuznetsov skuznets@redhat.com
/assign @sosiouxme @smarterclayton
/cc @openshift/developer-productivity-test-platform