re-adding promotion-validator to ci-tools #114
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
do-not-merge/work-in-progress
shiywang
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
shiywang
force-pushed
the
promotion-validator
branch
from
7dc8239 to
ff1e974
Compare
|
also cc @sosiouxme |
openshift-ci-robot
added
the
needs-rebase
shiywang
force-pushed
the
promotion-validator
branch
from
50f0487 to
51ab15a
Compare
openshift-ci-robot
removed
the
needs-rebase
|
@stevekuznetsov did you pass off responsibility for following up on this tool to anyone or should we still talk with you? @shiywang i lack the brain capacity at the moment to check this, just want to ask leading questions:
|
shiywang
force-pushed
the
promotion-validator
branch
from
51ab15a to
c1b5da5
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shiywang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi, @sosiouxme Here is what the tool does: 1.2 adding ose prefix to the image, then find in ocp-build-data (this is the old logic I don't what to break it) 1.4 print out all the images doesn't match also should fulfill condition 1.1 I think it addresses your question 2&&3, for 1 I am not sure what exactly you mean here? Here is the output I filtered out only left golang builder logs |
There was a problem hiding this comment.
@sosiouxme happy to commit to working with this
I would suggest we:
- create a list of necessary validations
- (optionally) factor this tool to run a set of validations as enabled by flags
- create a whitelist of current errors
- check in the tool to prevent future regressions
- work on fixing issues
5a. often this tool as written is pretty permissive for no great reason (like, the git URL can take any of 10 forms) -- I suggest making it restrictive and programatically changing the ocp-build-data to match
shiywang
force-pushed
the
promotion-validator
branch
from
c1b5da5 to
f427360
Compare
shiywang
force-pushed
the
promotion-validator
branch
from
f427360 to
5db6453
Compare
shiywang
force-pushed
the
promotion-validator
branch
2 times, most recently
from
3882baa to
7a59126
Compare
|
@tbielawa @sosiouxme since a lot of those errors are because of golang version not being explicit, are we still want to do this |
|
@stevekuznetsov @sosiouxme @tbielawa I rebase and re-run this command again there're three major problems I described on Jira, I think 80-90% percent of those issues can be fixed by
But for 2, the question is where do we put this white list, I don't like hardcoded into the ci-tools, we need to pick a place to put and make it configurable ^^^^^ questions above are solved |
…to d/s usage: ./promotion-validator --release-repo-dir /Users/shiywang/ART/release --ocp-build-data-repo-dir /Users/shiywang/ART/ocp-build-data --current-release 4.3
shiywang
force-pushed
the
promotion-validator
branch
from
7a59126 to
223044e
Compare
|
/retest |
|
@shiywang: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/close This is likely obsolete. Please open a new PR if still somehow relevant. |
|
@petr-muller: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is the bump from openshift/ci-operator-prowgen#121
The second commit is having a feature to detect golang builder differences between u/s && d/s jira