pkg/steps/clusterinstall/template: GCP region from the cluster #1533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I still wish the end-to-end suite pulled the region out of the cluster itself, but until it does, lean on the Infrastructure status [1] like we've been doing for AWS since openshift/release@bf0a271f5c (AWS e2e provider should identify zone and master and multizone, 2019-01-05, openshift/release#2507). The hard-coding I'm replacing here was fine until the GCP region became dynamic in 00ebab1 (pkg/steps/clusterinstall/template: Get region from Boskos lease, 2020-12-11, openshift#1527). [1]: https://github.com/openshift/api/blob/164a2fb63b5f12918c439a5a0a768aa911bcad99/config/v1/types_infrastructure.go#L327-L328
openshift-ci-robot
added
the
approved
|
just testing ci... |
|
/test lint |
alvaroaleman
approved these changes
Dec 17, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alvaroaleman, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I still wish the end-to-end suite pulled the region out of the cluster itself, but until it does, lean on the Infrastructure status like we've been doing for AWS since openshift/release@bf0a271f5c (openshift/release#2507). The hard-coding I'm replacing here was fine until the GCP region became dynamic in 00ebab1 (#1527).