Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/steps/clusterinstall/template: GCP region from the cluster #1533

Merged
merged 1 commit into from
Dec 17, 2020
Merged

pkg/steps/clusterinstall/template: GCP region from the cluster #1533

merged 1 commit into from
Dec 17, 2020

Commits on Dec 14, 2020

  1. pkg/steps/clusterinstall/template: GCP region from the cluster 

    I still wish the end-to-end suite pulled the region out of the cluster
itself, but until it does, lean on the Infrastructure status [1] like
we've been doing for AWS since openshift/release@bf0a271f5c (AWS e2e
provider should identify zone and master and multizone, 2019-01-05,
openshift/release#2507).  The hard-coding I'm replacing here was fine
until the GCP region became dynamic in 00ebab1
(pkg/steps/clusterinstall/template: Get region from Boskos lease,
2020-12-11, openshift#1527).

[1]: https://github.com/openshift/api/blob/164a2fb63b5f12918c439a5a0a768aa911bcad99/config/v1/types_infrastructure.go#L327-L328
    @wking
    wking committed Dec 14, 2020
    Configuration menu
    Copy the full SHA
    e9992dd View commit details
    Browse the repository at this point in the history