Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/steps/clusterinstall/template: Sync with openshift/release #401

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

Bringing over a number of changes which have landed in
ci-operator/templates/openshift/installer/cluster-launch-installer-e2e.yaml
as of openshift/release@c64d5d7d8f (Merge pull request #6845 from
wking/shared-subnets-for-other-regions, 2020-01-23).

One series was AWS region sharding:

* openshift/release@b7179335a3
  (ci-operator/templates/openshift/installer/cluster-launch-installer-*:
  Random AWS regions for IPI, 2020-01-23, openshift/release#6833).
* openshift/release@7e38260d25
  (ci-operator/templates/openshift/installer: Shared subnets for new
  regions, 2020-01-23, openshift/release#6845).

Another series was the password removal followed by a bunch of
pipefail fumbling ;)

* openshift/release@4847cb5477 (clean up install log output,
  2020-01-13, openshift/release#6692).
* openshift/release@5c6ca8a506 (templates: Use 'pipefail' so that grep
  doesn't mask install failures, 2020-01-15, openshift/release#6718).
* openshift/release@bee15b9fa8 (add -eou pipefail to remaining job
  templates, 2020-01-16, openshift/release#6738)
* openshift/release@07bd61d677 (Revert "add -eou pipefail to remaining
  job templates", 2020-01-17, openshift/release#6748).
* openshift/release@ca655477ca (Revert "Revert "add -eou pipefail to
  remaining job templates"", 2020-01-17, openshift/release#6750).
* openshift/release@9d7453156b (tolerate undefined env vars in
  teardown, 2020-01-17, openshift/release#6750).

And there was also:

* openshift/release@c6c2efb3fc (templates: Add ipv6 variant that
  triggers azure singlestack, 2020-01-22, openshift/release#6809).
* openshift/release@752455a47f (templates: fix check for unset
  variable, 2020-01-16, openshift/release#6723).
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 24, 2020
@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4cb20fc into openshift:master Jan 24, 2020
@wking wking deleted the bump-cluster-template branch April 3, 2020 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants