-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG 1858400: [Performance] Lease refresh period for machine-api-controllers is too high, causes heavy writes to etcd at idle #115
Conversation
@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
e858913
to
94d5160
Compare
@Danil-Grigorev: This pull request references Bugzilla bug 1858400, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
94d5160
to
57e2e9d
Compare
Prevent machine controllers from writing in etcd at idle too often by setting 120s lease, 20s retry and 110s deadline on all renewals. Higher values cause tests to flake. BZ 1858403
57e2e9d
to
3739cfa
Compare
/retest |
2 similar comments
/retest |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: elmiko The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm There was some outstanding conversation on the BZ, we can follow up with a second PR if needed |
i thought we had agreed to proceed with these patches and then add the releaseOnCancel stuff in a later patch? iiuc, these PRs that extend the time at least help the situation. |
Yeah sorry, it was based on our conversation that I gave the LGTM, we can follow up with releaseOnCancel later I believe |
@Danil-Grigorev: Some pull requests linked via external trackers have merged: openshift/machine-api-operator#675, openshift/machine-api-operator#649, openshift/cluster-api-provider-ovirt#56, openshift/cluster-api-provider-openstack#109, openshift/cluster-api-provider-gcp#115, openshift/cluster-api-provider-gcp#104, openshift/cluster-api-provider-baremetal#88. The following pull requests linked via external trackers have not merged:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reduce default lease retry rate on
30s
which will prevent from heavy writes into etcd at idle, and constrain renew deadline on90s
.Inspired by openshift/cloud-credential-operator#231
Depends on openshift/machine-api-operator#675