OCPBUGS-51305: ccm: disable unused secure-serving port and webhook #415

chrischdi · 2025-09-16T13:12:38Z

Disables the secure-serving port which is unused for all providers, except ibm and powervs where it is used as livenessprobe.

openshift-ci-robot · 2025-09-16T13:21:17Z

@chrischdi: This pull request references Jira Issue OCPBUGS-51305, which is invalid:

expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Disables the secure-serving port which is unused.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

chrischdi · 2025-09-16T13:23:39Z

/jira sync

chrischdi · 2025-09-16T13:23:59Z

/jira refresh

openshift-ci-robot · 2025-09-16T13:24:09Z

@chrischdi: This pull request references Jira Issue OCPBUGS-51305, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-09-16T13:52:52Z

@chrischdi: This pull request references Jira Issue OCPBUGS-51305, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.21.0) matches configured target version for branch (4.21.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

Disables the secure-serving port which is unused for all providers, except ibm and powervs where it is used as livenessprobe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

chrischdi · 2025-09-17T10:40:20Z

/retest

chrischdi · 2025-09-18T07:00:56Z

/retest-required

chrischdi · 2025-09-18T07:01:07Z

/retest

chrischdi · 2025-09-18T14:03:44Z

/retest-required

chrischdi · 2025-09-23T06:17:56Z

/retest

chrischdi · 2025-10-01T13:37:04Z

/retest

chrischdi · 2025-10-01T13:50:01Z

/assign mdbooth
/assign theobarberbany

Kindly asking fro some review :-)

chrischdi · 2025-10-02T07:26:44Z

/hold

Reverting the change for nutanix to see if that fixes CI

chrischdi · 2025-10-13T08:30:33Z

/retes

chrischdi · 2025-10-13T08:30:44Z

/retest

chrischdi · 2025-10-13T15:09:21Z

/retest

openshift-ci · 2025-10-13T19:23:57Z

@chrischdi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openstack-ovn	`ca9e78f`	link	false	`/test e2e-openstack-ovn`
ci/prow/e2e-nutanix-ovn	`ca9e78f`	link	false	`/test e2e-nutanix-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

chrischdi · 2025-10-14T11:03:46Z

/verified bypass

nutanix and openstack e2e permafailing. Verified manually that they don't have any active CCM webhooks:

❯ pwd
/Users/cschlott/go/src/github.com/openshift/cloud-provider-nutanix
❯ go run ./ --help | grep -e "--webhooks" -A 4
      --webhooks strings   A list of webhooks to enable. '*' enables all on-by-default webhooks, 'foo' enables the webhook named 'foo', '-foo' disables the webhook named 'foo'.
                           All webhooks:
                           Disabled-by-default webhooks:

Webhook serving flags:

❯ pwd
/Users/cschlott/go/src/github.com/openshift/cloud-provider-openstack
❯ go run ./cmd/openstack-cloud-controller-manager --help | grep -e "--webhooks" -A 4
      --webhooks strings   A list of webhooks to enable. '*' enables all on-by-default webhooks, 'foo' enables the webhook named 'foo', '-foo' disables the webhook named 'foo'.
                           All webhooks:
                           Disabled-by-default webhooks:

Webhook serving flags:

openshift-ci-robot · 2025-10-14T11:03:57Z

@chrischdi: The verified label has been added.

In response to this:

/verified bypass

nutanix and openstack e2e permafailing. Verified manually that they don't have any active CCM webhooks:

❯ pwd
/Users/cschlott/go/src/github.com/openshift/cloud-provider-nutanix
❯ go run ./ --help | grep -e "--webhooks" -A 4
     --webhooks strings   A list of webhooks to enable. '*' enables all on-by-default webhooks, 'foo' enables the webhook named 'foo', '-foo' disables the webhook named 'foo'.
                          All webhooks:
                          Disabled-by-default webhooks:

Webhook serving flags:

❯ pwd
/Users/cschlott/go/src/github.com/openshift/cloud-provider-openstack
❯ go run ./cmd/openstack-cloud-controller-manager --help | grep -e "--webhooks" -A 4
     --webhooks strings   A list of webhooks to enable. '*' enables all on-by-default webhooks, 'foo' enables the webhook named 'foo', '-foo' disables the webhook named 'foo'.
                          All webhooks:
                          Disabled-by-default webhooks:

Webhook serving flags:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-10-14T11:08:43Z

@chrischdi: Jira Issue OCPBUGS-51305 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Disables the secure-serving port which is unused for all providers, except ibm and powervs where it is used as livenessprobe.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

chrischdi · 2025-10-15T17:21:18Z

/jira backport release-4.20,release-4.19,release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

openshift-ci-robot · 2025-10-15T17:22:14Z

@chrischdi: The following backport issues have been created:

OCPBUGS-63164 for branch release-4.20
OCPBUGS-63165 for branch release-4.19
OCPBUGS-63166 for branch release-4.18
OCPBUGS-63167 for branch release-4.17
OCPBUGS-63168 for branch release-4.16
OCPBUGS-63169 for branch release-4.15
OCPBUGS-63170 for branch release-4.14

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.20,release-4.19,release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-cherrypick-robot · 2025-10-15T17:22:59Z

@openshift-ci-robot: #415 failed to apply on top of branch "release-4.14":

Applying: ccm: disable unused secure-serving port and webhook
Using index info to reconstruct a base tree...
M	pkg/cloud/aws/assets/deployment.yaml
M	pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/gcp/assets/cloud-controller-manager.yaml
M	pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/openstack/assets/deployment.yaml
M	pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/openstack/assets/deployment.yaml
Auto-merging pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/gcp/assets/cloud-controller-manager.yaml
CONFLICT (content): Merge conflict in pkg/cloud/gcp/assets/cloud-controller-manager.yaml
Auto-merging pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/aws/assets/deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 ccm: disable unused secure-serving port and webhook

In response to this:

@chrischdi: The following backport issues have been created:

OCPBUGS-63164 for branch release-4.20

OCPBUGS-63165 for branch release-4.19

OCPBUGS-63166 for branch release-4.18

OCPBUGS-63167 for branch release-4.17

OCPBUGS-63168 for branch release-4.16

OCPBUGS-63169 for branch release-4.15

OCPBUGS-63170 for branch release-4.14

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.20
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17
/cherrypick release-4.16
/cherrypick release-4.15
/cherrypick release-4.14

In response to this:

/jira backport release-4.20,release-4.19,release-4.18,release-4.17,release-4.16,release-4.15,release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-10-16T06:09:22Z

/cherrypick release-4.20

openshift-cherrypick-robot · 2025-10-16T06:10:07Z

@chrischdi: new pull request created: #419

In response to this:

/cherrypick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-10-16T06:11:30Z

/cherrypick release-4.19

openshift-cherrypick-robot · 2025-10-16T06:12:11Z

@chrischdi: new pull request created: #420

In response to this:

/cherrypick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-10-16T06:16:42Z

/cherrypick release-4.18

openshift-cherrypick-robot · 2025-10-16T06:17:23Z

@chrischdi: new pull request created: #421

In response to this:

/cherrypick release-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-10-16T06:40:35Z

/cherrypick release-4.17

/cherrypick release-4.16

openshift-cherrypick-robot · 2025-10-16T06:41:17Z

@chrischdi: new pull request created: #422

In response to this:

/cherrypick release-4.17

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

openshift-cherrypick-robot · 2025-10-16T06:41:58Z

@chrischdi: new pull request created: #423

In response to this:

/cherrypick release-4.17

/cherrypick release-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi · 2025-10-16T06:42:13Z

/cherrypick release-4.15

openshift-cherrypick-robot · 2025-10-16T06:42:55Z

@chrischdi: #415 failed to apply on top of branch "release-4.15":

Applying: ccm: disable unused secure-serving port and webhook
Using index info to reconstruct a base tree...
M	pkg/cloud/aws/assets/deployment.yaml
M	pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/gcp/assets/cloud-controller-manager.yaml
M	pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
M	pkg/cloud/openstack/assets/deployment.yaml
M	pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
Falling back to patching base and 3-way merge...
Auto-merging pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/vsphere/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/openstack/assets/deployment.yaml
Auto-merging pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/nutanix/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/gcp/assets/cloud-controller-manager.yaml
CONFLICT (content): Merge conflict in pkg/cloud/gcp/assets/cloud-controller-manager.yaml
Auto-merging pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/azurestack/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
CONFLICT (content): Merge conflict in pkg/cloud/azure/assets/cloud-controller-manager-deployment.yaml
Auto-merging pkg/cloud/aws/assets/deployment.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 ccm: disable unused secure-serving port and webhook

In response to this:

/cherrypick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

chrischdi changed the title ~~OCPBUGS-51305 aws: disable unused secure-serving port and webhook~~ OCPBUGS-51305: aws: disable unused secure-serving port and webhook Sep 16, 2025

openshift-ci bot requested review from mdbooth and theobarberbany September 16, 2025 13:21

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2025

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 16, 2025

openshift-ci bot requested a review from sunzhaohua2 September 16, 2025 13:24

chrischdi force-pushed the pr-aws-ccm-disable-webhook-port branch from 113f052 to 59e2736 Compare September 16, 2025 13:52

chrischdi changed the title ~~OCPBUGS-51305: aws: disable unused secure-serving port and webhook~~ OCPBUGS-51305: ccm: disable unused secure-serving port and webhook Sep 16, 2025

chrischdi force-pushed the pr-aws-ccm-disable-webhook-port branch from 59e2736 to afd7814 Compare September 16, 2025 14:04

ccm: disable unused secure-serving port and webhook

ca9e78f

chrischdi force-pushed the pr-aws-ccm-disable-webhook-port branch from afd7814 to ca9e78f Compare September 17, 2025 06:36

openshift-ci bot assigned mdbooth and theobarberbany Oct 1, 2025

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 2, 2025

chrischdi force-pushed the pr-aws-ccm-disable-webhook-port branch from b18e5db to ca9e78f Compare October 2, 2025 14:19

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 14, 2025

openshift-merge-bot bot merged commit 9f2dcd3 into openshift:main Oct 14, 2025
20 of 22 checks passed

openshift-cherrypick-robot mentioned this pull request Oct 16, 2025

[release-4.20] OCPBUGS-63164: ccm: disable unused secure-serving port and webhook #419

Open

openshift-cherrypick-robot mentioned this pull request Oct 16, 2025

[release-4.19] OCPBUGS-63165: ccm: disable unused secure-serving port and webhook #420

Open

openshift-cherrypick-robot mentioned this pull request Oct 16, 2025

[release-4.18] OCPBUGS-63166: ccm: disable unused secure-serving port and webhook #421

Open

openshift-cherrypick-robot mentioned this pull request Oct 16, 2025

[release-4.16] OCPBUGS-63168: ccm: disable unused secure-serving port and webhook #422

Open

openshift-cherrypick-robot mentioned this pull request Oct 16, 2025

[release-4.17] OCPBUGS-63167: ccm: disable unused secure-serving port and webhook #423

Open

This was referenced Oct 16, 2025

[release-4.15] OCPBUGS-63169: ccm: disable unused secure-serving port and webhook #424

Open

[release-4.14] OCPBUGS-63170: ccm: disable unused secure-serving port and webhook #425

Open

Uh oh!

OCPBUGS-51305: ccm: disable unused secure-serving port and webhook #415

OCPBUGS-51305: ccm: disable unused secure-serving port and webhook #415

Uh oh!

Conversation

chrischdi commented Sep 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Sep 16, 2025

Uh oh!

chrischdi commented Sep 16, 2025

Uh oh!

chrischdi commented Sep 16, 2025

Uh oh!

openshift-ci-robot commented Sep 16, 2025

Uh oh!

openshift-ci-robot commented Sep 16, 2025

Uh oh!

chrischdi commented Sep 17, 2025

Uh oh!

chrischdi commented Sep 18, 2025

Uh oh!

chrischdi commented Sep 18, 2025

Uh oh!

chrischdi commented Sep 18, 2025

Uh oh!

chrischdi commented Sep 23, 2025

Uh oh!

chrischdi commented Oct 1, 2025

Uh oh!

chrischdi commented Oct 1, 2025

Uh oh!

chrischdi commented Oct 2, 2025

Uh oh!

chrischdi commented Oct 13, 2025

Uh oh!

chrischdi commented Oct 13, 2025

Uh oh!

chrischdi commented Oct 13, 2025

Uh oh!

openshift-ci bot commented Oct 13, 2025

Uh oh!

chrischdi commented Oct 14, 2025

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

Uh oh!

openshift-ci-robot commented Oct 14, 2025

Uh oh!

chrischdi commented Oct 15, 2025

Uh oh!

openshift-ci-robot commented Oct 15, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 15, 2025

Uh oh!

chrischdi commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

chrischdi commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

chrischdi commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

chrischdi commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

chrischdi commented Oct 16, 2025

Uh oh!

openshift-cherrypick-robot commented Oct 16, 2025

Uh oh!

Reviewers

Assignees

Labels

chrischdi commented Sep 16, 2025 •

edited

Loading