-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure name #267
Infrastructure name #267
Conversation
/assign @dmage @adambkaplan |
@bparees @smarterclayton Do we need to disable checking for OWNER files in the vendor directory? |
Or prune non-Go, see my commit message here. |
/retest |
It's weird that in the error message the API group is empty. |
@wking Any thoughts on the error? |
/hold
|
Shouldn't need to do that, it needs to be updates for all CI/CD |
The following users are mentioned in OWNERS file(s) but are not members of the openshift org.
|
Yes, you do :) |
/retest |
Blocked by openshift/api#300 |
openshift/installer#1725 is in flight to unblock this. |
per @wking - we can push this to 4.2.
|
I dunno if you can adjust both tags in a single, atomic operation. If you can't, you'll want to add the |
@wking @adambkaplan |
Just reducing possible user confusion by removing a tag that no longer had semantic meaning. |
Blocked by openshift/installer#1725 |
@dmage ptal |
/hold cancel |
/lgtm |
/retest |
/retest |
/retest |
3 similar comments
/retest |
/retest |
/retest |
Uses infrastructures.config.openshift.io instead
@dmage ptal, tests are passing, Skipping baremetal test as we discussed. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: coreydaley, dmage The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Replaces #260
I hope that the few updates that I made will resolve the issues that we were seeing with #260, but the tests will tell.