pkg/asset/manifests/infrastructure: Set status.platformStatus.aws.region #1725
Conversation
openshift-ci-robot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
wking
force-pushed
the
api-infrastructure-aws-region
branch
2 times, most recently
from
f91803f
to
c528318
Compare
wking
force-pushed
the
api-infrastructure-aws-region
branch
from
c528318
to
ecaf8bf
Compare
Pulling in openshift/api@dedfb47b1f (config/v1/types_infrastructure: Add AWS Region, 2019-04-26, openshift/api#300). Generated with: $ dep ensure -update github.com/openshift/api using: $ dep version dep: version : v0.5.1 build date : 2019-03-20 git hash : faa61893 go version : go1.10.3 go compiler : gc platform : linux/amd64 features : ImportDuringSolve=false
Using openshift/api@dedfb47b1f (config/v1/types_infrastructure: Add AWS Region, 2019-04-26, openshift/api#300) so the registry can use it as a default for their config resource [1,2]. [1]: https://github.com/openshift/cluster-image-registry-operator/blob/670539cda460d97e0a3e23f077fdf9dd00d2ccdc/manifests/00-crd.yaml [2]: https://github.com/openshift/cluster-image-registry-operator/blob/670539cda460d97e0a3e23f077fdf9dd00d2ccdc/pkg/apis/imageregistry/v1/types.go#L179-L184
wking
force-pushed
the
api-infrastructure-aws-region
branch
from
ecaf8bf
to
8b3b375
Compare
openshift-ci-robot
added
size/L
|
Rebased onto master with ecaf8bf -> 8b3b375 now that #1718 has landed. Also fixed the |
|
@wking: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
Access to ec2 metadata will soon be restricted (openshift/origin#22826). Eliminate the ec2 metadata dependency by discovering AWS region information from cluster config. This commit uses the deprecated install config for metatadata; once openshift/installer#1725 merges, supported cluster config will provide the region information and the code can be refactored.
Access to ec2 metadata will soon be restricted (openshift/origin#22826). Eliminate the ec2 metadata dependency by discovering AWS region information from cluster config. This commit uses the deprecated install config for metatadata; once openshift/installer#1725 merges, supported cluster config will provide the region information and the code can be refactored.
Access to ec2 metadata will soon be restricted (openshift/origin#22826). Eliminate the ec2 metadata dependency by discovering AWS region information from cluster config. This commit uses the deprecated install config for metatadata; once openshift/installer#1725 merges, supported cluster config will provide the region information and the code can be refactored.
|
@wking: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@wking We would need a plan to set this up in existing clusters to make upgrades possible. Define a job in some operartor that ends up in release image that sets this field from cluster-config-v1. |
| case vsphere.Name: | ||
| config.Status.PlatformStatus.Type = configv1.VSpherePlatformType | ||
| case azure.Name: | ||
| config.Status.PlatformStatus.Type = configv1.AzurePlatformType |
There was a problem hiding this comment.
We also need LocationID for Azure, so that we know in which region we should create Storage Account.
|
@wking bump |
|
friendly ping on this 😃 |
|
@abhinavdahiya @wking any idea when this will get in? @cybertron needs to add info to the Baremetal PlatformStatus and I'm wondering if this needs to be getting merged first. |
Builds on #1718; I'll rebase after that lands.
Using openshift/api@dedfb47b1f (openshift/api#300) so the registry can use it as a default for their config resource.
This will allow the registry to move off the deprecated cluster-config-v1 (#680) and make it easier for them to move from
openshiftClusterIDtagging tokubernetes.io/cluster/{infraName}tagging (openshift/cluster-image-registry-operator#267), which is part of addressing rhbz#1685089.