Bug 1950284: Annotate services of type LoadBalancer with user tags (AWS only) #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
approved
|
/hold Accumulating things to do as I discover them and also to provide a link for the Jira ticket. |
openshift-ci-robot
added
the
do-not-merge/hold
frobware
changed the title
frobware
changed the title
Miciah
reviewed
Mar 24, 2021
sgreene570
reviewed
Mar 24, 2021
frobware
force-pushed
the
aws-label-LB-service
branch
from
268d6cf
to
7225afa
Compare
frobware
changed the title
frobware
force-pushed
the
aws-label-LB-service
branch
2 times, most recently
from
a0cef45
to
a92bb3e
Compare
openshift-ci-robot
added
the
needs-rebase
frobware
force-pushed
the
aws-label-LB-service
branch
from
a92bb3e
to
04ca6e6
Compare
openshift-ci-robot
removed
the
needs-rebase
frobware
force-pushed
the
aws-label-LB-service
branch
from
04ca6e6
to
65d537d
Compare
|
/retest |
|
@frobware: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-rebase
frobware
force-pushed
the
aws-label-LB-service
branch
2 times, most recently
from
048ce97
to
923b024
Compare
openshift-ci
bot
removed
the
needs-rebase
|
/test e2e-aws |
|
/retest |
frobware
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
frobware
force-pushed
the
aws-label-LB-service
branch
from
923b024
to
74952e2
Compare
frobware
changed the title
Thanks for catching this. Done in af1839e. |
If the infrastructure object (on AWS) has additional user supplied resource tags specified then annotate services of type LoadBalancer as follows: "service.beta.kubernetes.io/aws-load-balancer-additional-resource-tags": "Key1=Value1,KeyN=ValueN" https://issues.redhat.com/browse/NE-563 This is only done at create time, per the enhancement proposal. Existing services are not tagged. Equally, no reconciliation is done if the resource keys/values change.
frobware
force-pushed
the
aws-label-LB-service
branch
from
af1839e
to
946dc1e
Compare
|
/skip |
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: frobware, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-operator |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
failed to acquire lease: resources not found /test e2e-gcp-serial |
|
/test e2e-aws |
|
/retest |
|
failed to acquire lease: resources not found /test e2e-gcp-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@frobware: All pull requests linked via external trackers have merged: Bugzilla bug 1950284 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.7 |
|
@frobware: #578 failed to apply on top of branch "release-4.7": In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses https://issues.redhat.com/browse/NE-563.
This is waiting on:
If there are
AWS.UserTagsdefined then services of type LoadBalancerwill be annotated with the following annotation.
Values for this annotation are encoded as a comma separated list. For example:
The conceptual docs for this annotation are documented here:
https://kubernetes.io/docs/concepts/services-networking/service/#aws-load-balancer-additional-resource-tags
The operator will only add the annotation on create; there is no
ongoing reconciliation so changes to
AWS.UserTagswill not propagateonce the LoadBalancer service has been created.
There are restrictions on the key and values, documented here:
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/Using_Tags.html
Resources involved for classic (CLB) and network (NLB) differ.
Atomic create/tag issues on CLBs:
When a CLB is created (w.r.t. tags) the following happens:
then:
Atomic create/tag issues on NLBs:
When an NBL is created (w.r.t. tags) the following happens:
then:
Given that we only tag on create the following issues will not bite
immediately, but capturing them here for completeness: